user-agent string not being set on saucy
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
webbrowser-app |
Fix Released
|
High
|
Olivier Tilloy | ||
webbrowser-app (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
saucy-8 image
Galaxy Nexus
webbrowser-app 0.20daily13.
user-agent is not getting set correctly. It's falling through to the case where it doesn't get set at all in src/Ubuntu/
experimental.
// FIXME: using iOS 5.0’s iPhone/iPad user-agent strings
// (source: http://
// this should be changed to a more neutral user-agent in the
// future as we don’t want websites to recommend installing
// their iPhone/iPad apps.
if (formFactor === formFactor.phone) {
return "Mozilla/5.0 (iPhone; CPU iPhone OS 5_0 like Mac OS X) AppleWebKit/534.46 (KHTML, like Gecko) Version/5.1 Mobile/9A334 Safari/7534.48.3"
} else if (formFactor === formFactor.tablet) {
return "Mozilla/5.0 (iPad; CPU OS 5_0 like Mac OS X) AppleWebKit/534.46 (KHTML, like Gecko) Version/5.1 Mobile/9A334 Safari/7534.48.3"
} else {
return ""
}
}
Haven't debugged further, but causing website to render incorrectly.
Related branches
- PS Jenkins bot: Approve (continuous-integration)
- Günter Schwann (community): Approve
-
Diff: 15 lines (+2/-2)1 file modifiedsrc/Ubuntu/Browser/UbuntuWebView.qml (+2/-2)
Changed in webbrowser-app: | |
milestone: | none → ubuntu-13.06 |
assignee: | nobody → Olivier Tilloy (osomon) |
importance: | Undecided → High |
Changed in webbrowser-app: | |
status: | Confirmed → In Progress |
Changed in webbrowser-app: | |
status: | Fix Committed → Fix Released |
I can reliably reproduce the issue.
It appears to be a regression introduced by the new tabs functionality, where the webview was extracted into a separate UbuntuWebView component.