user-agent string not being set on saucy

Bug #1190409 reported by Bill Filler
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
webbrowser-app
Fix Released
High
Olivier Tilloy
webbrowser-app (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

saucy-8 image
Galaxy Nexus
webbrowser-app 0.20daily13.06.12-0ubuntu1

user-agent is not getting set correctly. It's falling through to the case where it doesn't get set at all in src/Ubuntu/Browser/UbuntuWebView.qml

 experimental.userAgent: {
        // FIXME: using iOS 5.0’s iPhone/iPad user-agent strings
        // (source: http://stackoverflow.com/questions/7825873/what-is-the-ios-5-0-user-agent-string),
        // this should be changed to a more neutral user-agent in the
        // future as we don’t want websites to recommend installing
        // their iPhone/iPad apps.
        if (formFactor === formFactor.phone) {
            return "Mozilla/5.0 (iPhone; CPU iPhone OS 5_0 like Mac OS X) AppleWebKit/534.46 (KHTML, like Gecko) Version/5.1 Mobile/9A334 Safari/7534.48.3"
        } else if (formFactor === formFactor.tablet) {
            return "Mozilla/5.0 (iPad; CPU OS 5_0 like Mac OS X) AppleWebKit/534.46 (KHTML, like Gecko) Version/5.1 Mobile/9A334 Safari/7534.48.3"
        } else {
            return ""
        }
    }

Haven't debugged further, but causing website to render incorrectly.

Related branches

Bill Filler (bfiller)
Changed in webbrowser-app:
milestone: none → ubuntu-13.06
assignee: nobody → Olivier Tilloy (osomon)
importance: Undecided → High
Revision history for this message
Olivier Tilloy (osomon) wrote :

I can reliably reproduce the issue.
It appears to be a regression introduced by the new tabs functionality, where the webview was extracted into a separate UbuntuWebView component.

Changed in webbrowser-app:
status: New → Confirmed
Olivier Tilloy (osomon)
Changed in webbrowser-app:
status: Confirmed → In Progress
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:webbrowser-app at revision 180, scheduled for release in webbrowser-app, milestone ubuntu-13.04-month-5

Changed in webbrowser-app:
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package webbrowser-app - 0.20daily13.06.14-0ubuntu1

---------------
webbrowser-app (0.20daily13.06.14-0ubuntu1) saucy; urgency=low

  [ Olivier Tilloy ]
  * Fix the conditional user-agent string based on form factor. (LP:
    #1190409)
  * Hide the forward button if there’s not enough screen real estate, as
    per design request. The visibility of chrome buttons now depends on
    the available width, regardless of orientation or form factor.

  [ Ubuntu daily release ]
  * Automatic snapshot from revision 181
 -- Ubuntu daily release <email address hidden> Fri, 14 Jun 2013 06:00:57 +0000

Changed in webbrowser-app (Ubuntu):
status: New → Fix Released
Olivier Tilloy (osomon)
Changed in webbrowser-app:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers