[webapp-container] Controls in header need same theme-color adjustments that text gets
Bug #1567430 reported by
Michael Terry
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| webapps-sprint |
Confirmed
|
Medium
|
Alexandre Abreu | ||
| webbrowser-app (Ubuntu) |
Fix Released
|
Medium
|
Alexandre Abreu | ||
Bug Description
This is a follow-on issue to bug 1548573.
In that bug, text color now is a more responsive to the background color of the header, chosen by "theme-color" in CSS.
But the controls of the header (back, forward, refresh) stay grey. Which is hard to see on some colors. They should become the same color as the header text.
Related branches
lp:~abreu-alexandre/webbrowser-app/theme-color-change-address-bar-widgets
- Alberto Mardegan (community): Approve
- system-apps-ci-bot: Needs Fixing (continuous-integration)
-
Diff: 241 lines (+134/-29)5 files modifiedsrc/app/webcontainer/Chrome.qml (+11/-1)
src/app/webcontainer/WebApp.qml (+2/-1)
tests/autopilot/webapp_container/tests/__init__.py (+3/-2)
tests/autopilot/webapp_container/tests/fake_servers.py (+45/-0)
tests/autopilot/webapp_container/tests/test_page_meta_collector.py (+73/-25)
| Changed in webbrowser-app (Ubuntu): | |
| assignee: | nobody → Alexandre Abreu (abreu-alexandre) |
| status: | New → Confirmed |
| Changed in webapps-sprint: | |
| assignee: | nobody → Alexandre Abreu (abreu-alexandre) |
| importance: | Undecided → Medium |
| Changed in webbrowser-app (Ubuntu): | |
| importance: | Undecided → Medium |
| Changed in webapps-sprint: | |
| status: | New → Confirmed |
| milestone: | none → sprint-21 |
| Changed in webapps-sprint: | |
| milestone: | sprint-21 → sprint-22 |
| Changed in webapps-sprint: | |
| milestone: | sprint-22 → sprint-23 |
| Changed in webapps-sprint: | |
| milestone: | sprint-23 → backlog |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #1 |
| Changed in webbrowser-app (Ubuntu): | |
| status: | Confirmed → Fix Released |
To post a comment you must log in.
This bug was fixed in the package webbrowser-app - 0.23+16.
---------------
webbrowser-app (0.23+16.
* Set the front camera as the default for video media requests (LP:
#1563398)
* Handle theme color change and properly update browsing widgets (LP:
#1567430)
* Properly propagate touchscreen detection flag (LP: #1585689)
* Print help when no app-id is present (LP: #1591306)
-- Alexandre Abreu <email address hidden> Mon, 20 Jun 2016 15:08:41 +0000