[Google+] Login is broken; auth. sequence ends up ejected into the browser
Bug #1614126 reported by
David Barth
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| The Webapps-core project |
In Progress
|
Critical
|
Alberto Mardegan | ||
| webapps-sprint |
In Progress
|
Critical
|
Alberto Mardegan | ||
Bug Description
Trying to logon with Google+, the OA auth. trust prompt passes, then we get redirected to a web logon page, inside the webapp. And that finally gets ejected into the browser, because that's not detected as a valid SAML destination.
Related branches
lp:~mardy/webapps-core/saml-1614126
- Ubuntu Phablet Team: Pending requested
-
Diff: 5136 lines (+3844/-484)62 files modifiedwebapp-googleplus/lib/AlertDialog.qml (+6/-3)
webapp-googleplus/lib/BeforeUnloadDialog.qml (+7/-3)
webapp-googleplus/lib/ConfirmDialog.qml (+7/-3)
webapp-googleplus/lib/ContentHandler.qml (+35/-0)
webapp-googleplus/lib/Downloader.qml (+26/-32)
webapp-googleplus/lib/FileExtensionMapper.js (+27/-7)
webapp-googleplus/lib/MimeTypeMapper.js (+49/-15)
webapp-googleplus/lib/ModalDialog.qml (+4/-4)
webapp-googleplus/lib/PromptDialog.qml (+8/-5)
webapp-googleplus/lib/WebViewImpl.qml (+50/-34)
webapp-googleplus/lib/actions/Back.qml (+2/-2)
webapp-googleplus/lib/actions/Bookmark.qml (+2/-2)
webapp-googleplus/lib/actions/BookmarkLink.qml (+2/-2)
webapp-googleplus/lib/actions/ClearHistory.qml (+2/-2)
webapp-googleplus/lib/actions/Copy.qml (+2/-2)
webapp-googleplus/lib/actions/CopyImage.qml (+2/-2)
webapp-googleplus/lib/actions/CopyLink.qml (+2/-2)
webapp-googleplus/lib/actions/Cut.qml (+23/-0)
webapp-googleplus/lib/actions/Erase.qml (+23/-0)
webapp-googleplus/lib/actions/FindInPage.qml (+27/-0)
webapp-googleplus/lib/actions/Forward.qml (+2/-2)
webapp-googleplus/lib/actions/GoTo.qml (+2/-2)
webapp-googleplus/lib/actions/NewTab.qml (+2/-2)
webapp-googleplus/lib/actions/OpenImageInNewTab.qml (+2/-2)
webapp-googleplus/lib/actions/OpenLinkInBrowser.qml (+23/-0)
webapp-googleplus/lib/actions/OpenLinkInNewBackgroundTab.qml (+23/-0)
webapp-googleplus/lib/actions/OpenLinkInNewTab.qml (+2/-2)
webapp-googleplus/lib/actions/OpenLinkInNewWindow.qml (+23/-0)
webapp-googleplus/lib/actions/OpenLinkInPrivateWindow.qml (+23/-0)
webapp-googleplus/lib/actions/OpenVideoInNewTab.qml (+23/-0)
webapp-googleplus/lib/actions/Paste.qml (+23/-0)
webapp-googleplus/lib/actions/Redo.qml (+23/-0)
webapp-googleplus/lib/actions/Reload.qml (+2/-2)
webapp-googleplus/lib/actions/SaveImage.qml (+2/-2)
webapp-googleplus/lib/actions/SaveLink.qml (+23/-0)
webapp-googleplus/lib/actions/SaveVideo.qml (+23/-0)
webapp-googleplus/lib/actions/SelectAll.qml (+23/-0)
webapp-googleplus/lib/actions/Share.qml (+24/-0)
webapp-googleplus/lib/actions/Undo.qml (+23/-0)
webapp-googleplus/lib/webcontainer/AccountChooserDialog.qml (+124/-0)
webapp-googleplus/lib/webcontainer/AccountErrorScreen.qml (+54/-0)
webapp-googleplus/lib/webcontainer/AccountItem.qml (+31/-0)
webapp-googleplus/lib/webcontainer/AccountsLogic.qml (+231/-0)
webapp-googleplus/lib/webcontainer/AccountsPage.qml (+137/-0)
webapp-googleplus/lib/webcontainer/AccountsSplashScreen.qml (+89/-0)
webapp-googleplus/lib/webcontainer/Chrome.qml (+160/-0)
webapp-googleplus/lib/webcontainer/ContentDownloadDialog.qml (+45/-27)
webapp-googleplus/lib/webcontainer/ContentPickerDialog.qml (+9/-27)
webapp-googleplus/lib/webcontainer/ContextMenuMobile.qml (+162/-0)
webapp-googleplus/lib/webcontainer/ContextMenuWide.qml (+158/-0)
webapp-googleplus/lib/webcontainer/OnlineAccountsController.qml (+66/-0)
webapp-googleplus/lib/webcontainer/PopupWindowController.qml (+266/-0)
webapp-googleplus/lib/webcontainer/PopupWindowOverlay.qml (+248/-0)
webapp-googleplus/lib/webcontainer/SadPage.qml (+56/-0)
webapp-googleplus/lib/webcontainer/SplashScreen.qml (+65/-0)
webapp-googleplus/lib/webcontainer/WebApp.qml (+323/-0)
webapp-googleplus/lib/webcontainer/WebViewImplOxide.qml (+297/-0)
webapp-googleplus/lib/webcontainer/WebappContainerWebview.qml (+139/-0)
webapp-googleplus/lib/webcontainer/WebappWebview.qml (+234/-0)
webapp-googleplus/lib/webcontainer/webapp-container.qml (+336/-0)
webapp-googleplus/manifest.json (+1/-1)
webapp-googleplus/webview-override.qml (+16/-295)
| Changed in webapps-core: | |
| assignee: | nobody → Alberto Mardegan (mardy) |
| status: | New → Triaged |
| Changed in webapps-sprint: | |
| assignee: | nobody → Alberto Mardegan (mardy) |
| status: | New → Triaged |
| milestone: | none → sprint-26 |
Revision history for this message
| Alberto Mardegan (mardy) wrote | #1 |
| Changed in webapps-sprint: | |
| status: | Triaged → Incomplete |
Revision history for this message
| David Barth (dbarth) wrote | #2 |
| Changed in webapps-sprint: | |
| milestone: | sprint-26 → sprint-27 |
Revision history for this message
| Alberto Mardegan (mardy) wrote | #3 |
| Changed in webapps-sprint: | |
| milestone: | sprint-27 → sprint-28 |
| Changed in webapps-core: | |
| status: | Triaged → In Progress |
| Changed in webapps-sprint: | |
| status: | Incomplete → In Progress |
| Changed in webapps-core: | |
| importance: | Undecided → High |
| importance: | High → Critical |
| Changed in webapps-sprint: | |
| importance: | Undecided → Critical |
Revision history for this message
| Alberto Mardegan (mardy) wrote | #4 |
| Changed in webapps-sprint: | |
| milestone: | sprint-28 → sprint-29 |
To post a comment you must log in.
Which version of webbrowser-app do you have installed?
This sounds a lot like bug 1573017, which should be already fixed (except in xenial).