CI jobs on master (train) are not receiving nova versioned notifications

[Matt Riedemann]

Since https://review.opendev.org/#/c/603079/ in nova the default notification format is unversioned so watcher CI jobs are not receiving nova versioned notifications and that CDM code isn't being tested in those integration jobs.

[Matt Riedemann (mriedem)]

Working on fixing the watcher CI job configuration here: https://review.opendev.org/#/c/663332/

[Matt Riedemann (mriedem)]

Devstack patch: https://review.opendev.org/#/c/662849/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/667161

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/663332
Committed: https://git.openstack.org/cgit/openstack/watcher/commit/?id=966a4dfa5f030d4b88e4902c9f762a2d6213a670
Submitter: Zuul
Branch: master

commit 966a4dfa5f030d4b88e4902c9f762a2d6213a670
Author: Matt Riedemann <email address hidden>
Date: Wed Jun 5 09:33:11 2019 -0400

    Configure nova notification format in non-grenade CI jobs

    Nova used to emit versioned and unversioned notiifcations
    by default but that changed in https://review.opendev.org/603079/
    so now nova emits only unversioned notifications by default.
    Watcher listens for versioned notifications so we need to configure
    nova to emit both versioned (for Watcher) and unversioned
    (for Ceilometer) notifications explicitly.

    This adds an override-defaults file so devstack will load up
    the nova devstack variable to set the notification_format before
    importing and stacking the nova lib script.

    Note that this only fixes the non-grenade CI jobs since grenade
    requires separate handling for overriding defaults which is proving
    hard to do and will be addressed in a separate change.

    Partial-Bug: #1831917

    Change-Id: I7e441608b38338eecd80e663ed3abe66a89e504f

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/667161
Committed: https://git.openstack.org/cgit/openstack/watcher/commit/?id=9c9f336f1086256452554b236954753f15b9d4a8
Submitter: Zuul
Branch: master

commit 9c9f336f1086256452554b236954753f15b9d4a8
Author: Matt Riedemann <email address hidden>
Date: Mon Jun 24 13:07:17 2019 -0400

    Configure nova notification_format for grenade

    Nova changed the default notification_format from "both" to
    "unversioned" in Train [1]. Without configuring nova in the
    grenade job we are not testing the nova versioned notification
    handler code during upgrades.

    Note that grenade only runs stack.sh on the base (old) side so
    this change has to depend on a devstack stable/stein change to
    add the NOVA_NOTIFICATION_FORMAT variable that we override.

    Closes-Bug: #1831917

    Depends-On: Ied9d50b07c368d5c2be658c744f340a8d1ee41e0

    [1] https://review.opendev.org/603079/

    Change-Id: I94c2d14477da185310e0fec596a1ad6436b802f1

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/watcher 3.0.0.0rc1 release candidate.