watcher dashboard: Oneshot Audit Create failed

Bug #1783683 reported by YumengBao
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
watcher
Fix Released
High
YumengBao

Bug Description

When using Watcher dashboard to create an audit, the following situation occurs:
We fail to create a ONESHOT audit with Dummy Goal and Dummy Strategy, however a CONTUNIOUS audit with Dummy Goal and Dummy Strategy and 90 seconds intervals can be successfully created.

YumengBao (yumeng-bao)
Changed in watcher:
importance: Undecided → High
assignee: nobody → YumengBao (yumeng-bao)
milestone: none → rocky-rc
status: New → In Progress
summary: - Oneshot Audit Create failed
+ watcher dashboard: Oneshot Audit Create failed
Revision history for this message
YumengBao (yumeng-bao) wrote :

The problem is caused by the "Interval " in the CreateForm, where Interval (in seconds or cron format) was a compulsory parameter no matter what audit_type it is.
In fact, the situation should be when the audit_type is ONESHOT, it is unnecessary to have Interval.
when the audit_type is CONTINUOUS, "Interval" parameter is required.
So here, the solution is: set the Interval parameter to required=False, and check if the parameter is null when audit_type is CONTINUOUS.

Revision history for this message
YumengBao (yumeng-bao) wrote :

This patch fixes the bug: https://review.openstack.org/#/c/585961/

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to watcher-dashboard (master)

Reviewed: https://review.openstack.org/585961
Committed: https://git.openstack.org/cgit/openstack/watcher-dashboard/commit/?id=ec4aea5aaab98c072ad51af9af6d5bfd8db96b81
Submitter: Zuul
Branch: master

commit ec4aea5aaab98c072ad51af9af6d5bfd8db96b81
Author: Yumeng Bao <email address hidden>
Date: Thu Jul 26 14:02:20 2018 +0800

    Set interval parameter to optional and add validation before audit create

    This patch fixes dashboard bug: Oneshot Audit Create failed

    Change-Id: Ic3f8833a5091226abb22b8260cdc5adf8711c279
    Closes-Bug: #1783683

Changed in watcher:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/watcher-dashboard 1.11.0

This issue was fixed in the openstack/watcher-dashboard 1.11.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.