Missing unit tests on watcher/common/nova_helper.py

Bug #1599849 reported by Vincent Françoise on 2016-07-07
This bug affects 1 person
Affects Status Importance Assigned to Milestone

Bug Description

As of now, the nova helper is heavily used by most of the strategies although it does not have a sufficient code coverage.

The objective here would be to raise its coverage to at least 80% (with useful tests).

Changed in watcher:
importance: Undecided → Low
Changed in watcher:
status: New → Triaged
milestone: none → newton-3
licanwei (li-canwei2) on 2016-07-13
Changed in watcher:
assignee: nobody → licanwei (li-canwei2)

Fix proposed to branch: master
Review: https://review.openstack.org/343135

Changed in watcher:
status: Triaged → In Progress

Reviewed: https://review.openstack.org/343135
Committed: https://git.openstack.org/cgit/openstack/watcher/commit/?id=6144551809c939570e47bab288604b25aa3cab21
Submitter: Jenkins
Branch: master

commit 6144551809c939570e47bab288604b25aa3cab21
Author: licanwei <email address hidden>
Date: Sat Jul 16 12:11:26 2016 +0800

    Add unit tests for nova_helper.py

    The nova helper does not have a sufficient code coverage.
    This commit raises its coverage from 39% to 89%.
    And unit tests find two bugs.

    Closes-Bug: #1607198
    Change-Id: Iebb693cd09e512ce44702eddca8ead0c7310b263
    Closes-Bug: #1599849

Changed in watcher:
status: In Progress → Fix Released

This issue was fixed in the openstack/watcher 0.29.0 release.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers