Remove unused columns parameters in watcher/db/api.py

Bug #1597641 reported by Vincent Françoise on 2016-06-30
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
watcher
Low
Muzammil

Bug Description

In watcher/db/api.py, some abstract methods are specifying a 'columns' parameter that is actually ignored in db/sqlalchemy/api.py. Since we do not need this parameter, we need to make re-align the signatures of these methods by removing the 'column' parameter (and its docstring) from every single one of them.

Here is a list of the methods to update:

    def get_audit_template_list(self, context, columns=None, filters=None,
                                limit=None, marker=None, sort_key=None,
                                sort_dir=None):

    def get_audit_list(self, context, columns=None, filters=None, limit=None,
                       marker=None, sort_key=None, sort_dir=None):

    def get_action_list(self, context, columns=None, filters=None, limit=None,
                        marker=None, sort_key=None, sort_dir=None):

    def get_action_plan_list(
            self, context, columns=None, filters=None, limit=None,
            marker=None, sort_key=None, sort_dir=None):

Changed in watcher:
importance: Undecided → Low
Changed in watcher:
assignee: nobody → Muzammil (muzammil-mueen)
Changed in watcher:
status: Triaged → In Progress
Muzammil (muzammil-mueen) wrote :

Fixed proposed on master

https://review.openstack.org/336392

Changed in watcher:
milestone: none → newton-3

Reviewed: https://review.openstack.org/336392
Committed: https://git.openstack.org/cgit/openstack/watcher/commit/?id=fd7c41fba2e51f25ec7649a0b5187ffbfb253635
Submitter: Jenkins
Branch: master

commit fd7c41fba2e51f25ec7649a0b5187ffbfb253635
Author: Muzammil Mueen <email address hidden>
Date: Thu Jun 30 13:02:28 2016 -0700

    Remove unused columns parameters in watcher/db/api

    In watcher/db/api.py, some abstract methods are specifying a 'columns'
    parameter that is actually ignored in db/sqlalchemy/api.py. Since we
    do not need this parameter, realignment was done for the signatures
    of these methods, by removing the 'column' parameter (and its
    docstring) from every single one of the following methods.

    get_audit_template_list
    get_audit_list
    get_action_list
    get_action_plan_list

    Closes-Bug: #1597641
    Change-Id: If706e24d5714f0139fd135bdc41d17d0e431e302

Changed in watcher:
status: In Progress → Fix Released

This issue was fixed in the openstack/watcher 0.29.0 release.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers