Add @abc.abstract in .coveragerc

Bug #1563717 reported by Vincent Françoise on 2016-03-30
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
watcher
Wishlist
Larry Rensing

Bug Description

As we import modules and not function/decorators directly, we need to add @abc.abstract in the exclude_lines option in the .coveragerc file.

Changed in watcher:
status: New → Triaged
milestone: none → newton-1
Larry Rensing (lr699s) on 2016-03-30
Changed in watcher:
assignee: nobody → Larry Rensing (lr699s)
Changed in watcher:
importance: Undecided → Wishlist

Fix proposed to branch: master
Review: https://review.openstack.org/299565

Changed in watcher:
status: Triaged → In Progress

Reviewed: https://review.openstack.org/299565
Committed: https://git.openstack.org/cgit/openstack/watcher/commit/?id=8387cd10de998e046f960a221a51a4ce60f92453
Submitter: Jenkins
Branch: master

commit 8387cd10de998e046f960a221a51a4ce60f92453
Author: Larry Rensing <email address hidden>
Date: Wed Mar 30 17:59:23 2016 +0000

    Update .coveragerc to ignore abstract methods

    Due to importing modules rather than functions and decorators directly,
    @abc.abstract and 'raise NotImplementedError' were added to the
    .coveragerc file. Since abstract methods are not testable, this will
    give us a more accurate representation of our coverage.

    Change-Id: Id5ed5e1f5e142d10f41ad18d20228399226ec20d
    Co-Authored-By: Jin Li <email address hidden>
    Closes-Bug: #1563717

Changed in watcher:
status: In Progress → Fix Released

This issue was fixed in the openstack/watcher 0.27.0 release.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers