bad default value for neutron client version

[David TARDIVEL]

test platform : devstack
watcher version: 0.23.2

I did not add the section [neutron_client] in my watcher.conf configuration file. So Watcher DE takes into account the default value as the version of neutron client.

I have this error

2016-02-10 15:52:28.427 ERROR watcher.decision_engine.audit.default [req-d4f6eebe-5404-4e8f-a456-31c3b3a8c63a ] Invalid network client version '2'. must be one of: 2.0
2016-02-10 15:52:28.427 TRACE watcher.decision_engine.audit.default Traceback (most recent call last):
2016-02-10 15:52:28.427 TRACE watcher.decision_engine.audit.default File "/opt/stack/watcher/watcher/decision_engine/audit/default.py", line 77, in execute
2016-02-10 15:52:28.427 TRACE watcher.decision_engine.audit.default request_context)
2016-02-10 15:52:28.427 TRACE watcher.decision_engine.audit.default File "/opt/stack/watcher/watcher/decision_engine/strategy/context/default.py", line 55, in execute_strategy
2016-02-10 15:52:28.427 TRACE watcher.decision_engine.audit.default collector_manager = self.collector.get_cluster_model_collector(osc=osc)
2016-02-10 15:52:28.427 TRACE watcher.decision_engine.audit.default File "/opt/stack/watcher/watcher/metrics_engine/cluster_model_collector/manager.py", line 34, in get_cluster_model_collector
2016-02-10 15:52:28.427 TRACE watcher.decision_engine.audit.default nova = nova_helper.NovaHelper(osc=osc)
2016-02-10 15:52:28.427 TRACE watcher.decision_engine.audit.default File "/opt/stack/watcher/watcher/common/nova_helper.py", line 38, in __init__
2016-02-10 15:52:28.427 TRACE watcher.decision_engine.audit.default self.neutron = self.osc.neutron()
2016-02-10 15:52:28.427 TRACE watcher.decision_engine.audit.default File "/opt/stack/watcher/watcher/common/exception.py", line 52, in wrapped
2016-02-10 15:52:28.427 TRACE watcher.decision_engine.audit.default return func(*args, **kw)
2016-02-10 15:52:28.427 TRACE watcher.decision_engine.audit.default File "/opt/stack/watcher/watcher/common/clients.py", line 156, in neutron
2016-02-10 15:52:28.427 TRACE watcher.decision_engine.audit.default session=self.session)
2016-02-10 15:52:28.427 TRACE watcher.decision_engine.audit.default File "/usr/local/lib/python2.7/dist-packages/neutronclient/neutron/client.py", line 69, in Client
2016-02-10 15:52:28.427 TRACE watcher.decision_engine.audit.default API_VERSIONS,
2016-02-10 15:52:28.427 TRACE watcher.decision_engine.audit.default File "/usr/local/lib/python2.7/dist-packages/neutronclient/common/utils.py", line 60, in get_client_class
2016-02-10 15:52:28.427 TRACE watcher.decision_engine.audit.default raise exceptions.UnsupportedVersion(msg)
2016-02-10 15:52:28.427 TRACE watcher.decision_engine.audit.default UnsupportedVersion: Invalid network client version '2'. must be one of: 2.0

The default value for neutron client (value = 2) is not correct. It should be 2.0

https://github.com/openstack/watcher/blob/master/watcher/common/clients.py#L49

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/278483

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/278483
Committed: https://git.openstack.org/cgit/openstack/watcher/commit/?id=a4a009a2c641d4daada9d60fc7396e7303d5586e
Submitter: Jenkins
Branch: master

commit a4a009a2c641d4daada9d60fc7396e7303d5586e
Author: David TARDIVEL <email address hidden>
Date: Wed Feb 10 17:04:34 2016 +0100

    Update the default version of Neutron API

    Default value of Neutron API should be 2.0 in neutronclient.
    Closes-Bug: #1544134

    Change-Id: I241c067c33c992da53f30e974ffca3edb466811d