watcher

clean imports in code

Bug #1543101 reported by Jean-Emile DARTOIS
This bug report is a duplicate of:  Bug #1594434: Import module instead of class. Edit Remove
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
watcher
In Progress
Low
Unassigned
watcher newton-2 "n2"

Bug Description

We need to fix things like (imports in the openstack way / openstack hacking rules)
Example:
from watcher.applier.manager import ApplierManager
-> from watcher.applier import manager

See original description
Jean-Emile DARTOIS (jed56)
Changed in watcher:
importance: Undecided → Low
milestone: none → mitaka-3
tags: added: low-hanging-fruit
Steve Wilkerson (srwilker)
Changed in watcher:
assignee: nobody → Steve Wilkerson (sw5822)
Revision history for this message
Jean-Emile DARTOIS (jed56) wrote :

Partial-Bug:https://review.openstack.org/#/c/277369

description: updated
Steve Wilkerson (srwilker)
Changed in watcher:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to watcher (master)

Reviewed: https://review.openstack.org/277369
Committed: https://git.openstack.org/cgit/openstack/watcher/commit/?id=5baff7dc3e65c857ced20bb10b69b76a4299acf2
Submitter: Jenkins
Branch: master

commit 5baff7dc3e65c857ced20bb10b69b76a4299acf2
Author: Jean-Emile DARTOIS <email address hidden>
Date: Mon Feb 8 13:51:20 2016 +0100

    Clean imports in code

    In some part in the code we import objects.
    In the Openstack style guidelines they recommand
    to import only modules.
    We need to fix that.

    Change-Id: I4bfee2b94d101940d615f78f9bebb83310ed90ba
    Partial-Bug:1543101

Antoine Cabot (antoinecabot)
Changed in watcher:
milestone: mitaka-3 → mitaka-rc-1
Steve Wilkerson (srwilker)
Changed in watcher:
assignee: Steve Wilkerson (srwilker) → nobody
Antoine Cabot (antoinecabot)
Changed in watcher:
milestone: mitaka-rc-1 → mitaka-rc-final
Antoine Cabot (antoinecabot)
Changed in watcher:
milestone: mitaka-rc-final → newton-1
Steve Wilkerson (srwilker)
Changed in watcher:
assignee: nobody → Steve Wilkerson (srwilker)
Vincent Françoise (vincent-francoise)
Changed in watcher:
milestone: newton-1 → newton-2
assignee: Steve Wilkerson (srwilker) → nobody
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/355326
Committed: https://git.openstack.org/cgit/openstack/watcher/commit/?id=17d2d75abb11d42c31a3f2a708f3675754d30819
Submitter: Jenkins
Branch: master

commit 17d2d75abb11d42c31a3f2a708f3675754d30819
Author: Nguyen Hung Phuong <email address hidden>
Date: Mon Aug 15 13:40:56 2016 +0700

    Clean imports in code

    In some part in the code we import objects.
    In the Openstack style guidelines they recommand to import
    only modules. We need to fix that.

    Change-Id: I268c5045f00d25b4dfbf77c1f599c7baca8373ed
    Partial-Bug:1543101

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.