Unused parameter in get_last_sample_values()

Bug #1541415 reported by Gábor Antal on 2016-02-03
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
watcher
Low
Gábor Antal

Bug Description

In watcher/common/ceilometer_help.py:129, there is an unused parameter in
  def get_last_sample_values(self, resource_id, meter_name, limit=1):

We should remove that

Changed in watcher:
assignee: nobody → Gábor Antal (gabor.antal)
Changed in watcher:
status: New → In Progress
Changed in watcher:
importance: Undecided → Low
milestone: none → mitaka-3
Gábor Antal (gabor.antal) wrote :

Reviewed: https://review.openstack.org/275727
Committed: https://git.openstack.org/cgit/openstack/watcher/commit/?id=f32995228b1ef174a2ce9543c993033ac57168c0
Submitter: Jenkins
Branch: master

commit f32995228b1ef174a2ce9543c993033ac57168c0
Author: Gábor Antal <email address hidden>
Date: Wed Feb 3 15:35:37 2016 +0100

    Pass parameter to the query in get_last_sample_values

    In watcher/common/ceilometer_help.py:129,
    there is an unused parameter, called limit:
      def get_last_sample_values(self, resource_id, meter_name, limit=1):

    In the next line, there is a method call which can take this
    currently unused 'limit' parameter. Probably, passing this 'limit'
    parameter to the query was originally intended, however it wasn't
    added to the query call.

    Closes-Bug: #1541415
    Change-Id: I025070c6004243d6b8a6ea7a1d83081480c4148b

Changed in watcher:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers