Remove direct access to dbapi in Watcher Applier

Bug #1534170 reported by Jean-Emile DARTOIS on 2016-01-14
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
watcher
Wishlist
Taylor Peoples

Bug Description

In line : https://github.com/openstack/watcher/blob/master/watcher/applier/default.py#L36
we directly use the dbapi in order to filter the actions by action_plan_id.

We should use a dedicated function in the action_plan.py file to do it.

https://github.com/openstack/watcher/blob/ee82531314e45ec0ffd4b0135fc9080c42c7c800/watcher/api/controllers/v1/action_plan.py

description: updated
Changed in watcher:
importance: Undecided → Wishlist
status: New → Confirmed
Changed in watcher:
milestone: none → mitaka-3
Changed in watcher:
assignee: nobody → Taylor Peoples (tpeoples)
Changed in watcher:
milestone: mitaka-3 → mitaka-rc-1
Changed in watcher:
milestone: mitaka-rc-1 → mitaka-rc-final
Changed in watcher:
milestone: mitaka-rc-final → newton-1
Changed in watcher:
milestone: newton-1 → newton-2

Reviewed: https://review.openstack.org/315813
Committed: https://git.openstack.org/cgit/openstack/watcher/commit/?id=dbdf690cd0442a5099ef15375a379ce7400fdb84
Submitter: Jenkins
Branch: master

commit dbdf690cd0442a5099ef15375a379ce7400fdb84
Author: Tin Lam <email address hidden>
Date: Thu May 12 18:50:30 2016 -0500

    Remove direct access to dbapi

    In line [1], we directly use the dbapi in order to
    filter the actions by action_plan_id.

    [1] https://github.com/openstack/watcher/blob/master/watcher/applier/default.py#L63

    Change-Id: I2c75528f619a5277d46702cc3b4ca4bc7280f990
    Closes-Bug: #1534170

Changed in watcher:
status: Confirmed → Fix Released

This issue was fixed in the openstack/watcher 0.28.0 release.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers