State STARTING for Action Plan should be changed to TRIGGERED

Bug #1533245 reported by Vincent Mahe
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-watcherclient
High
Vincent Françoise
watcher
Wishlist
Vincent Françoise

Bug Description

There is an intermediate state for action_plan named STARTING.
This state is used to change the current state of the action_plan when the Administrator has sent a PATCH HTTP request to the Watcher API on resource /v1/action_plans
See https://factory.b-com.com/www/watcher/doc/watcher/webapi/v1.html#actionplans

A message is then sent on the AMQP bus and the state of the action_plan is changed to ONGOING as soon as the Watcher Applier receives the message and starts launching the Action Plan (see class DefaultActionPlanHandler).

Therefore the state STARTING should rather be named TRIGGERED.
IMHO, it would be more relevant to indicate that a request has been sent on the bus for executing the action_plan.

Changed in watcher:
status: New → Confirmed
importance: Low → Wishlist
summary: - State STARTING for Action Plan should be changed to SUBMITTED
+ State STARTING for Action Plan should be changed to TRIGGERED
description: updated
Changed in watcher:
status: Confirmed → In Progress
assignee: nobody → Vincent Françoise (vincent-francoise)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to watcher (master)

Reviewed: https://review.openstack.org/269700
Committed: https://git.openstack.org/cgit/openstack/watcher/commit/?id=4dfe6a3fa8ea6002e00b103c94f3cf09ce953c56
Submitter: Jenkins
Branch: master

commit 4dfe6a3fa8ea6002e00b103c94f3cf09ce953c56
Author: Vincent Françoise <email address hidden>
Date: Tue Jan 19 16:06:26 2016 +0100

    Action Plan state - Changed STARTING to TRIGGERED

    As the STARTING state was not clear on its meaning, I renamed it
    to TRIGGERED.

    Change-Id: I99cceeb57f3d7d42c1543b21fad88a6872bc4e55
    Closes-Bug: #1533245

Changed in watcher:
status: In Progress → Fix Released
Changed in python-watcherclient:
milestone: none → mitaka-2
status: New → In Progress
importance: Undecided → High
assignee: nobody → Vincent Françoise (vincent-francoise)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to python-watcherclient (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/272124

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to python-watcherclient (master)

Reviewed: https://review.openstack.org/272124
Committed: https://git.openstack.org/cgit/openstack/python-watcherclient/commit/?id=59c0dc667eb4832f56578c0b4b4b901caab594f3
Submitter: Jenkins
Branch: master

commit 59c0dc667eb4832f56578c0b4b4b901caab594f3
Author: Vincent Francoise <email address hidden>
Date: Mon Jan 25 15:56:18 2016 +0100

    Updated STARTING to TRIGGERED

    Following https://review.openstack.org/269700, we now have to make the
    same changes to the python-watcherclient project.

    Change-Id: I894508dc3b04dd0f24101c5dfb396116f41dc23f
    Related-Bug: #1533245

Changed in python-watcherclient:
status: In Progress → Fix Committed
Changed in python-watcherclient:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers