watcher

Strategy goal required have to be True

Bug #1531116 reported by Jean-Emile DARTOIS on 2016-01-05
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
​ watcher
Fix Released
Medium
Gábor Antal
watcher mitaka-2 "m2"
Also affects project (?) Also affects distribution/package Nominate for series

Bug Description

In the section "WATCHER_GOALS_OPTS" the dict option "goals" is not mandatory. However it should be.

So we need to add "required=True"
The code is available here :
https://github.com/openstack/watcher/blob/master/watcher/decision_engine/strategy/selection/default.py#L33

WATCHER_GOALS_OPTS = [
    cfg.DictOpt(
        'goals',
        default=default_goals,
        required=True,
        help='Goals used for the optimization. '
             'Maps each goal to an associated strategy (for example: '
             'BASIC_CONSOLIDATION:basic, MY_GOAL:my_strategy_1)'),
]

See original description
Jean-Emile DARTOIS (jed56) on 2016-01-05
description: updated
Gábor Antal (gabor.antal) on 2016-01-05
Changed in watcher:
assignee: nobody → Gábor Antal (gabor.antal)
OpenStack Infra (hudson-openstack) wrote : Fix proposed to watcher (master)

Fix proposed to branch: master
Review: https://review.openstack.org/263725

Changed in watcher:
status: New → In Progress
Vincent Françoise (vincent-francoise) on 2016-01-05
Changed in watcher:
importance: Undecided → Low
importance: Low → Medium
OpenStack Infra (hudson-openstack) wrote : Fix merged to watcher (master)

Reviewed: https://review.openstack.org/263725
Committed: https://git.openstack.org/cgit/openstack/watcher/commit/?id=34ab93a5f20cc64bdaaca676545d536aeaa8d58f
Submitter: Jenkins
Branch: master

commit 34ab93a5f20cc64bdaaca676545d536aeaa8d58f
Author: Gábor Antal <email address hidden>
Date: Tue Jan 5 14:12:06 2016 +0100

    Strategy goals should be required in conf

    In the section "WATCHER_GOALS_OPTS" the dict option "goals"
    is not mandatory. However it should be.

    Change-Id: I2e0770cf7787fed449c012bc45462e3138992ebf
    Closes-Bug: #1531116

Changed in watcher:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.
Subscribing...

Other bug subscribers