Add unit test for watcher/doc.py

Bug #1527163 reported by Jean-Emile DARTOIS on 2015-12-17
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
watcher
Low
Vincent Françoise

Bug Description

Although the "Include terminology definition from docstring" pathset got merged https://review.openstack.org/#/c/256419/ we discovered that the class watcher/doc.py has no unit test.

description: updated
Changed in watcher:
assignee: nobody → Steve Wilkerson (sw5822)

The difficulty with this ticket is that the doc generation is not currently possible in python 3.4 which means that adding tests on it will make the py34 gate to fail. So just like other projects did (see nova with https://github.com/openstack/nova/blob/master/tox.ini#L49), we have to skip these unit tests in python 3.4

Changed in watcher:
milestone: none → mitaka-3
importance: Undecided → Low
Changed in watcher:
assignee: Steve Wilkerson (sw5822) → nobody
Changed in watcher:
assignee: nobody → Gábor Antal (gabor.antal)
Changed in watcher:
status: New → In Progress
Changed in watcher:
status: In Progress → New
Changed in watcher:
assignee: Gábor Antal (gabor.antal) → nobody
sai (saigandham467) on 2016-02-24
Changed in watcher:
assignee: nobody → sai (saigandham467)
assignee: sai (saigandham467) → nobody
Changed in watcher:
milestone: mitaka-3 → mitaka-rc-final
Changed in watcher:
status: New → Triaged
Changed in watcher:
milestone: mitaka-rc-final → newton-1
description: updated
Changed in watcher:
milestone: newton-1 → newton-2
Changed in watcher:
assignee: nobody → Digambar (digambarpatil15)
Changed in watcher:
milestone: newton-2 → newton-3
tags: added: test
Digambar (digambarpatil15) wrote :

Doc-related directives in nova, they do not provide any test for them, we have to move it out of watcher package and put it in the doc/ folder.
We will follow path what nova has taken.

Changed in watcher:
assignee: Digambar (digambarpatil15) → Vincent Françoise (vincent-francoise)

Fix proposed to branch: master
Review: https://review.openstack.org/382411

Changed in watcher:
status: Triaged → In Progress

Reviewed: https://review.openstack.org/382411
Committed: https://git.openstack.org/cgit/openstack/watcher/commit/?id=96357aec04960e467a65bb32a049235a2ba25ed6
Submitter: Jenkins
Branch: master

commit 96357aec04960e467a65bb32a049235a2ba25ed6
Author: Vincent Françoise <email address hidden>
Date: Wed Oct 5 15:22:50 2016 +0200

    Moved Watcher doc plugin outside main package

    In this changeset, I renamed watcher/doc.py file as
    doc/ext/term.py which subsequently does not get scanned for coverage
    anymore. Hence, we can close this bug.

    Change-Id: I9d700da6569b464ce71085fe78002521555002b9
    Closes-bug: #1527163

Changed in watcher:
status: In Progress → Fix Released

This issue was fixed in the openstack/watcher 0.32.0 release.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers