watcher

prepare_service() - duplicate function

Bug #1525842 reported by Vincent Françoise
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
watcher
Fix Released
Low
Gábor Antal
watcher mitaka-2 "m2"

Bug Description

The prepare_service() function is defined both in watcher/service.py and in watcher/common/service.py.

These 2 should be merged into a single one to avoid code duplication.

At the same time, the watcher/service.py only contains this function, so if we move it to watcher/common/service.py, we should also delete the file as a whole.

Vincent Françoise (vincent-francoise)
Changed in watcher:
importance: Undecided → Low
milestone: none → mitaka-2
Gábor Antal (gabor.antal)
Changed in watcher:
assignee: nobody → Gábor Antal (gabor.antal)
OpenStack Infra (hudson-openstack)
Changed in watcher:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to watcher (master)

Reviewed: https://review.openstack.org/258007
Committed: https://git.openstack.org/cgit/openstack/watcher/commit/?id=f0b58f8c2717339901683e79c439e8423ae4bab3
Submitter: Jenkins
Branch: master

commit f0b58f8c2717339901683e79c439e8423ae4bab3
Author: Gábor Antal <email address hidden>
Date: Tue Dec 15 17:48:40 2015 +0100

    Removed duplicated function prepare_service()

    The prepare_service() function is defined both in watcher/service.py
    and in watcher/common/service.py.

    These 2 needed to be merged into a single one
    to avoid code duplication.

    At the same time, the watcher/service.py only contains this function,
    so I removed that file.

    Change-Id: I0c935dfcd011bee9597315752dae8668221c53f9
    Closes-Bug: #1525842

Changed in watcher:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.