watcher

Statuses - 3 classes with the same name

Bug #1522733 reported by Vincent Françoise
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
watcher
Fix Released
Low
Vincent Françoise
watcher mitaka-2 "m2"

Bug Description

As we can see in the codebase, we have 3 "Status" enums which are located at:

- watcher/objects/action.py
- watcher/objects/action_plan.py
- watcher/objects/audit.py

To make it more consistent with the DB, the objective would be rename them as "State" and prefix each one of them (e.g. ActionState) as they are meant to be different although it looks like duplicated code.
Adding a docstring to each one of them would be appreciated.

See original description
Vincent Françoise (vincent-francoise)
Changed in watcher:
importance: Undecided → Low
Steve Wilkerson (srwilker)
Changed in watcher:
assignee: nobody → Steve Wilkerson (sw5822)
Steve Wilkerson (srwilker)
Changed in watcher:
assignee: Steve Wilkerson (sw5822) → nobody
assignee: nobody → Steve Wilkerson (sw5822)
status: New → In Progress
Antoine Cabot (antoinecabot)
Changed in watcher:
milestone: none → mitaka-2
Steve Wilkerson (srwilker)
Changed in watcher:
assignee: Steve Wilkerson (sw5822) → nobody
Vincent Françoise (vincent-francoise)
Changed in watcher:
assignee: nobody → Vincent Françoise (vincent-francoise)
Vincent Françoise (vincent-francoise)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to watcher (master)

Fix proposed to branch: master
Review: https://review.openstack.org/269551

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to watcher (master)

Reviewed: https://review.openstack.org/269551
Committed: https://git.openstack.org/cgit/openstack/watcher/commit/?id=62b39fefbb988ff0fbeefe4fac679fa60255c5c5
Submitter: Jenkins
Branch: master

commit 62b39fefbb988ff0fbeefe4fac679fa60255c5c5
Author: Vincent Françoise <email address hidden>
Date: Tue Jan 19 11:52:06 2016 +0100

    Renamed Status to State

    As we can see in the codebase, we have 3 "Status" enums which are
    located at:

    - watcher/objects/action.py
    - watcher/objects/action_plan.py
    - watcher/objects/audit.py

    So I renamed them from "Status" to "State" to be consistent with
    the DB schema.

    Change-Id: If3d180c9daba6ae9083775ad6813aa4c21763dbf
    Closes-Bug: #1522733

Changed in watcher:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.