Statuses - 3 classes with the same name
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
| watcher |
Low
|
Vincent Françoise |
Bug Description
As we can see in the codebase, we have 3 "Status" enums which are located at:
- watcher/
- watcher/
- watcher/
To make it more consistent with the DB, the objective would be rename them as "State" and prefix each one of them (e.g. ActionState) as they are meant to be different although it looks like duplicated code.
Adding a docstring to each one of them would be appreciated.
Changed in watcher: | |
importance: | Undecided → Low |
Changed in watcher: | |
assignee: | nobody → Steve Wilkerson (sw5822) |
Changed in watcher: | |
assignee: | Steve Wilkerson (sw5822) → nobody |
assignee: | nobody → Steve Wilkerson (sw5822) |
status: | New → In Progress |
Changed in watcher: | |
milestone: | none → mitaka-2 |
Changed in watcher: | |
assignee: | Steve Wilkerson (sw5822) → nobody |
Changed in watcher: | |
assignee: | nobody → Vincent Françoise (vincent-francoise) |
description: | updated |
Reviewed: https:/
Committed: https:/
Submitter: Jenkins
Branch: master
commit 62b39fefbb988ff
Author: Vincent Françoise <email address hidden>
Date: Tue Jan 19 11:52:06 2016 +0100
Renamed Status to State
As we can see in the codebase, we have 3 "Status" enums which are
located at:
- watcher/
- watcher/
- watcher/
So I renamed them from "Status" to "State" to be consistent with
the DB schema.
Change-Id: If3d180c9daba6a
Closes-Bug: #1522733
Changed in watcher: | |
status: | In Progress → Fix Released |
Fix proposed to branch: master /review. openstack. org/269551
Review: https:/