MessagingCore - reference to a self.client only defined in children

Bug #1521636 reported by Vincent Françoise on 2015-12-01
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
watcher
Low
Vincent Françoise

Bug Description

In the "check_api_version()" method of the MessagingCore class, we can see that a reference to a self.client is made albeit being undefined in its __init__() contructor.

The objective would be to fix this issue by either making sure it is defined in MessagingCore.__init__()

Changed in watcher:
importance: Undecided → Low
Darren Shaw (dronshaw) on 2015-12-04
Changed in watcher:
assignee: nobody → Darren Shaw (ds354m)

Fix proposed to branch: master
Review: https://review.openstack.org/253856

Changed in watcher:
status: New → In Progress
Changed in watcher:
milestone: none → mitaka-2
Antoine Cabot (antoinecabot) wrote :

Darren, your review is still in progress, could you please give a status on this fix ? thx

Darren Shaw (dronshaw) wrote :

Antoine,

I've had my free time exponentially taken by other responsibilities since the first patchset! Everything should be complete, except for unit testing within /tests/common/messaging/test_message_core.py

Given I may not have the ability to focus on this watcher issue for some time, is this something I could collaborate with another individual on? I'm not sure on the usual approach to this dilemma from a community standpoint would be. Thanks!

Antoine Cabot (antoinecabot) wrote :

no problem Darren, we will keep your code and create a new review with unit tests, I'd like to have this fixed in mitaka-2 that's why I asked you for an update.

Changed in watcher:
assignee: Darren Shaw (ds354m) → nobody
Changed in watcher:
milestone: mitaka-2 → mitaka-3
Changed in watcher:
milestone: mitaka-3 → mitaka-2
Changed in watcher:
assignee: nobody → Vincent Françoise (vincent-francoise)
Changed in watcher:
milestone: mitaka-2 → mitaka-3

Reviewed: https://review.openstack.org/253856
Committed: https://git.openstack.org/cgit/openstack/watcher/commit/?id=2f0c1c12cf6cfa1921ab1c5e7b858b4f33800ff0
Submitter: Jenkins
Branch: master

commit 2f0c1c12cf6cfa1921ab1c5e7b858b4f33800ff0
Author: Darren Shaw <email address hidden>
Date: Sat Dec 5 18:53:44 2015 -0600

    Define self.client in MessagingCore

    Currently self.client is referenced within MessagingCore,
    but no definition is made in its constructor. Additionally
    self.client is defined in children classes of MessagingCore.
    This patchset defines self.client in the constructor of
    MessagingCore and removes the redefinition in its children.

    -self.client lazily loaded

    Co-Authored-By: v-francoise <email address hidden>
    Change-Id: I14525a175bf1ebde3d2636024ad2f2219c79d6e1
    Closes-Bug: #1521636

Changed in watcher:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers