Add support for more resolutions

Bug #685144 reported by Pali
18
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Stargus
Won't Fix
High
Pali
Stratagus
Fix Released
High
Pali
Wargus
Fix Released
High
Kyran Jackson

Bug Description

Most of netbooks support 1024x600 resolution, why not add it to the list of options?

Pali (pali)
Changed in wargus:
status: New → Triaged
importance: Undecided → High
assignee: nobody → Pali (pali)
Revision history for this message
Kyran Jackson (erstmap) wrote :

I've made the adjustments to scripts/menus/options.lua

I've also added the generic Stratagus header to it.

The copywrite is incomplete as well. Pali added the OpenGL options recently, but I have no idea who the original author is. Probably Jimmy Salmon or Lutz Sammer.

No patch, just the straight LUA file.

Revision history for this message
Pali (pali) wrote :

Please generate patch, so I can apply it to bzr.

What other resolution will be good to support?

Revision history for this message
Kyran Jackson (erstmap) wrote :
Revision history for this message
Kyran Jackson (erstmap) wrote :

There will need to be another patch to deal with the graphics showing up correctly for the hud ingame. I'll take care of it either today or tomorrow.

Revision history for this message
Kyran Jackson (erstmap) wrote :
Revision history for this message
Kyran Jackson (erstmap) wrote :

The changes I've made to the ui.lua files should allow the hud to be drawn with any resolution up to and including 1680x1200.

Changed in wargus:
status: Triaged → In Progress
Revision history for this message
Kyran Jackson (erstmap) wrote :

I've added a few more resolutions, and have started working on introducing support for 320x240. I'm uploading the LUA here so I don't lose it. :)

I don't believe it's ready to be commited, so no patch as of yet. I still want to introduce sound options.

Revision history for this message
Kyran Jackson (erstmap) wrote :
Revision history for this message
Kyran Jackson (erstmap) wrote :
Revision history for this message
Roman Held (rheld) wrote :

-------------------------
b = menu:addCheckBox("1366 x 768", offx + 16*15, offy + 55 + 26*1.4,
      function() SetVideoSize(13660, 768) menu:stop(1) end)
-------------------------
13660? That would be a nice screen... ;)

Revision history for this message
Pali (pali) wrote :

Now setting resolution is implemented in
 * Stratagus engine (passing by command line with arg -v):
    stratagus/src/stratagus/stratagus.cpp:887
 * In game extractor (wartool):
    wargus/wartool.c:679
 * In Lua option script:
    wargus/scripts/menus/options.lua:157

These patches does not solve problems in other game then Wargus.

Better soulution would be Creating function in Stratagus for getting all supported resolution by system and export this function to Lua. Then in game (Wargus, Stargus, ...) will can this function and render checkboxes of supported resolutions.

Any other suggestion for my solution?

summary: - Resolution 1024x600
+ Add support for more resolutions
Changed in stratagus:
assignee: nobody → Pali (pali)
importance: Undecided → High
status: New → In Progress
Changed in stargus:
status: New → In Progress
importance: Undecided → High
assignee: nobody → Pali (pali)
Revision history for this message
Pali (pali) wrote :

I changed format of option -v for setting initial resolution in Stratagus to <xres>x<yres>. So now it is possible to start Stratagus with any resolution (supported by OS/graphic card...)

Changed in stratagus:
status: In Progress → Fix Committed
milestone: none → 2.2.6
Revision history for this message
Kyran Jackson (erstmap) wrote :

If you haven't already could you add my patches for each race's UI file?

/scripts/human/ui.lua
/scripts/orc/ui.lua

My updates make it so it can draw the UI with custom resolutions.

Revision history for this message
Pali (pali) wrote :

Your patches for ui.lua is bad solution. Resultions must be added to warextract.c

Revision history for this message
Pali (pali) wrote :

EDIT: not to warextract.c but to wartool.c

Revision history for this message
Travis (dinky-dye-aussie) wrote :

If it means anything, I have been working on updating all the interface pieces using Photoshop. I have so far only updated the in-game interface that you see when you're actually playing the game. I've mostly been working on the orc one, and have almost finished covering all the resolutions supported - it looks really good with the updated interface - no stretched images anymore, but it still has that semi classic look to it too.

I had a thought about making the interfaces for warcraft 1 as well, and you would only need to modify/create new lua files and then you would have a full working - better looking version of the warcraft 1 game. Just a thought anyways.

I'll have a play with the LUA files sometime once I have all the interface images sorted out, and see if I can put up with playing through warcraft 1 so I can jott down the objectives and units allowed/denied and the same with buildings as well. should be fun.

Revision history for this message
Kyran Jackson (erstmap) wrote :

Share some pictures. :)

Revision history for this message
Tilpa (fabio-pasini) wrote :

> I had a thought about making the interfaces for warcraft 1 as well,
> and you would only need to modify/create new lua files
> and then you would have a full working - better looking
> version of the warcraft 1 game. Just a thought anyways.

Hey !! That's cool! :)
It would be someting nice to add into War1gus!

Also, Travis, were you able to continue (or finish) those image enhancements?

Pali (pali)
Changed in stratagus:
status: Fix Committed → Fix Released
Revision history for this message
Travis (dinky-dye-aussie) wrote :

I've done a new set of images for the interfaces on both the human and orc interfaces, as I lost my last lot when I installed the latest version of the game files, but they look more amazing again cos I've learnt even more skills with photoshop. I will try to get some screenshots up on my photobucket page or something so I can link them to you here.

I also redesigned the buttons for all the units and buildings, and modified the appropriate LUA ui files to reflect the changes. It's looking more and more like the original but higher res.

Revision history for this message
Travis (dinky-dye-aussie) wrote :

I have put a new screenshot of my interface being used in Wargus - http://forums.stratagus.com/viewtopic.php?f=7&t=2863&sid=40721a6effaf356f149b9cd41eef6fee

I have also modified "options.lua" with a heap of new resolutions, including 1024x600, and have seperated them into 4:3 and Widescreen (16:9/16:10) menus, so now anyone who wants to make the game a certain resolution, can do so easily in the Options menu, in game when playing Wargus.

I'll try and upload my modified options.lua file so poeple can get it to use - just make sure you backup your copy too.

Revision history for this message
Travis (dinky-dye-aussie) wrote :

OK I got no idea how to update the Wargus trunk. so I'll upload the LUA file here.

Just put it in wargus\scripts\menu\

it will ask to replace the existing "options.lua", if you've backed up your original, then go right ahead and say yes :)

If you have any problems let me know.

Revision history for this message
Kyran Jackson (erstmap) wrote :

I get the impression you didn't look at the discussion at the start of this thread. Now we've got two updated option.lua files.

Revision history for this message
Pali (pali) wrote :

My idea is to fix it properly - not only add some resolutions which somebody wants. Stratagus can now start with any resolution and Wargus and Stargus should have option to specify any resolutions (not only prepaired some from this bug). I will look at this problem in Wargus and Stargus later. I also know that some images in Wargus has hardcoded resolution into images itself...

Revision history for this message
cybermind (iddqd-mail) wrote :

I'm wondering why don't use listbox instead of these checkboxes? And don't make a lot of graphics for each resolution, but use the CGraphic:Resize(w,h) function for smaller resolutions.
Here is a screenshot showing how I remade the options menu in Doom Wars.

Revision history for this message
Pali (pali) wrote :

+ add input text box for specifing your own resolution

this sounds good. other thing is to remove duplicates graphics for each resolution (in wargus)...

Revision history for this message
rusix (ruslannesmashnyy) wrote :

Wargus come to iOs?

Revision history for this message
tomas banach (bladum) wrote : Re: [Bug 685144] Re: Add support for more resolutions

Hi,

I join Wargus team a long time ago but actually did nothing :(

Now i see question about iOS. This is interesting because i work with
Corona SDK (based on Lua) to make iOS games under www.bladko.com :)

Currently i just cannot afford to work on free, open source project but
want to let you know about me, iOS and Lua :)

Tom

On Sat, Dec 8, 2012 at 1:24 PM, rusix <email address hidden> wrote:

> Wargus come to iOs?
>
> --
> You received this bug notification because you are subscribed to Wargus.
> https://bugs.launchpad.net/bugs/685144
>
> Title:
> Add support for more resolutions
>
> Status in Stargus - Starcraft I:
> In Progress
> Status in Stratagus:
> Fix Released
> Status in Wargus - Warcraft II:
> In Progress
>
> Bug description:
> Most of netbooks support 1024x600 resolution, why not add it to the
> list of options?
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/stargus/+bug/685144/+subscriptions
>

--
wielki wojownik o nicość

Kyran Jackson (erstmap)
Changed in wargus:
status: In Progress → Fix Committed
assignee: Pali (pali) → Kyran Jackson (erstmap)
Revision history for this message
Marc Thibeault (marcthibeault) wrote :

1920x1080 would be pretty neat too.

cybermind (iddqd-mail)
Changed in wargus:
status: Fix Committed → Fix Released
milestone: none → 2.3
Revision history for this message
timfelgentreff (timfelgentreff) wrote : Moving to GitHub

This project was moved to https://github.com/Wargus/stargus. All issues were migrated there.

Changed in stargus:
status: In Progress → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Related questions

Remote bug watches

Bug watches keep track of this bug in other bug trackers.