build system: make paths modifiable and respect LDFLAGs

Bug #1005271 reported by hasufell on 2012-05-27
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Wargus
Fix Released
Undecided
Pali

Bug Description

paths are not modifiable and system/env LDFLAGs get overwritten.

patch attached.

Related branches

hasufell (jd-o) wrote :
Pali (pali) wrote :

Hi, first thanks for patch! It has one problem, that pixmaps path is hardcoded in stratagus file src/video/sdl.cpp to /usr/share/pixmaps/. Can you fix this first?

hasufell (jd-o) wrote :

right, the desktop file also needs a fix

working on that

Pali (pali) wrote :

Ok, I commited this patch to bzr trunk. Fixed in rev 1661: http://bazaar.launchpad.net/~stratagus/wargus/trunk/revision/1661

Changed in wargus:
milestone: none → 2.2.7
assignee: nobody → Pali (pali)
status: New → Fix Committed
hasufell (jd-o) wrote :

for the desktop file I would suggest to change it to "wargus.desktop.in" with:

[Desktop Entry]
Name=Wargus - Warcraft II
Comment=Warcraft II data game set for the Stratagus engine
Exec=@DESKTOPBIN@/wargus
Icon=wargus
Terminal=false
Type=Application
Categories=Game;StrategyGame;
StartupNotify=false

and in CMakeLists.txt:

# desktop file
if(NOT IS_ABSOLUTE "${BINDIR}")
 set(DESKTOPBIN "${CMAKE_INSTALL_PREFIX}/${BINDIR}")
else()
 set(DESKTOPBIN "${BINDIR}")
endif()
configure_file (
  "${PROJECT_SOURCE_DIR}/wargus.desktop.in"
  "${PROJECT_BINARY_DIR}/wargus.desktop"
  )

hasufell (jd-o) wrote :

on the other hand we could just fix it to

Exec=wargus

and expect the user to have that bindir in his PATH ;)

Pali (pali) on 2012-08-20
Changed in wargus:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers