build system: make paths modifiable and respect LDFLAGs

[hasufell]

paths are not modifiable and system/env LDFLAGs get overwritten.

patch attached.

[Pali (pali)]

Hi, first thanks for patch! It has one problem, that pixmaps path is hardcoded in stratagus file src/video/sdl.cpp to /usr/share/pixmaps/. Can you fix this first?

[hasufell (jd-o)]

right, the desktop file also needs a fix

working on that

[Pali (pali)]

Ok, I commited this patch to bzr trunk. Fixed in rev 1661: http://bazaar.launchpad.net/~stratagus/wargus/trunk/revision/1661

[hasufell (jd-o)]

for the desktop file I would suggest to change it to "wargus.desktop.in" with:

[Desktop Entry]
Name=Wargus - Warcraft II
Comment=Warcraft II data game set for the Stratagus engine
Exec=@DESKTOPBIN@/wargus
Icon=wargus
Terminal=false
Type=Application
Categories=Game;StrategyGame;
StartupNotify=false

and in CMakeLists.txt:

# desktop file
if(NOT IS_ABSOLUTE "${BINDIR}")
 set(DESKTOPBIN "${CMAKE_INSTALL_PREFIX}/${BINDIR}")
else()
 set(DESKTOPBIN "${BINDIR}")
endif()
configure_file (
  "${PROJECT_SOURCE_DIR}/wargus.desktop.in"
  "${PROJECT_BINARY_DIR}/wargus.desktop"
  )

[hasufell (jd-o)]

on the other hand we could just fix it to

Exec=wargus

and expect the user to have that bindir in his PATH ;)

[Pali (pali)]

Fixed in https://bazaar.launchpad.net/~stratagus/wargus/trunk/revision/1668