| 2012-05-02 07:59:13 |
newbuntu |
description |
cannot save wakeup-settings if "reccurs" is selected. then, wakeup doesn't not work |
cannot save wakeup-settings if "reccurs" is selected. then, wakeup doesn't not work
[Impact]
This bug is quite crippling, as it prevents users from setting any recurring alarm, which is how virtually every user will use the application. (e.g., how do you use the alarm clock on your nightstand?)
[Development Fix]
For the development branch, this has been fixed precisely as detailed below using the posted patch. The plan is to include this as version 1.3 for Ubuntu 12.10 along with other feature additions. Presumably, as this is a very minor fix code-wise, it would be released back to precise as version 1.2-0ubuntu2.
[Stable Fix]
The patch is attached in the postings below, and has been confirmed as working by users. The patch is practically a one-liner, and is so small I include the contents here:
39,40c39
< cronstring = re.sub("\*", '"*"', cronstring)
< crontimes.append(re.sub('"', '', cronstring))
---
> crontimes.append(cronstring)
[Test Case]
Steps for reproducing the bug:
1. Open wakeup ($ wakeup-settings), also available through the dash.
2. Click ok to exit the introduction dialog if this is the first time running wakeup
3. Click "Preferences"
4. Under the "General tab" (should be first visible), check "Recurrs".
5. Click "Ok"
6. Click "Apply" in the main window.
7. Enter password to continue
8. Dialog appears saying "Unable to set all alarms. Check time preferences. Unable to set alarms. Some crontimes are invalid." (this is the bug, one cannot set recurrent alarms).
[Regression Potential]
Recurring alarms were of course available in previous releases. Upgrading may break current recurring alarms, as they are maintained by the buggy file setnextalarm.py, and will break the ability to reset or modify any alarms the users already have saved, as well as add any new recurring alarms. |
|
