Segfault when playing URL that redirects
Bug #1462464 reported by
Kyle
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Vocal |
New
|
Undecided
|
Unassigned |
Bug Description
Some RSS sites use redirects for tracking and analytics. For example all the podcasts here use it:
http://
If you play any of these videos vocal will crash with a segfault.
I have created a fix that will use the correct URL and prevent a segfault from happening regardless.
Related branches
lp:~agronick/vocal/vocal
Ready for review
for merging
into
lp:vocal
- Nathan Dyer: Pending requested
-
Diff: 448 lines (+114/-117)4 files modifiedCMakeLists.txt (+2/-1)
src/Objects/Episode.vala (+7/-3)
src/Utils/Player.vala (+103/-112)
src/Widgets/EpisodeDetailBox.vala (+2/-1)
It turns out that the problem was not caused by redirects. It was segfaulting because the timeout was too small. I added code to prevent the segmentation fault on an empty response and increased the timeout to 30 seconds.