2 Gtk.MessageDialog confirmations in file MainWindow.vala not set for translation

[Jiri Grönroos]

Package: 1.0+284-0~ubuntu0.3.1

http://bazaar.launchpad.net/~nathandyer/vocal/trunk/view/head:/src/MainWindow.vala#L1747
                     "Are you sure you want to mark all episodes from '%s' as played?".printf(highlighted_podcast.name.replace("%27", "'")));

http://bazaar.launchpad.net/~nathandyer/vocal/trunk/view/head:/src/MainWindow.vala#L1992
                     "Are you sure you want to remove '%s' from your library?".printf(highlighted_podcast.name.replace("%27", "'")));

Both of these confirmation dialogs are not set for translation.

[Jiri Grönroos (jiri-gronroos)]

Sorry for spamming with i18n bugs. The latter confirmation dialog also uses Gtk.ButtonsType.NONE and sets Gtk.Buttons itself. Yes and No values are not set for translation

 msg.add_button ("_No", Gtk.ResponseType.CANCEL); should most likely be (_("_No"), Gtk.ResponseType.CANCEL);

 Gtk.Button delete_button = (Gtk.Button) msg.add_button("_Yes", Gtk.ResponseType.YES); should likely be msg.add_button(_("_Yes"), Gtk.ResponseType.YES);

[Nathan Dyer (nathandyer)]

Thanks for all your i18n bug reports! This issue is now fixed in Vocal 2.0 as well.