Wrong pre-delete checks for distributed routers

Bug #1479309 reported by Salvatore Orlando on 2015-07-29
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
neutron
Undecided
Unassigned
Juno
Undecided
Salvatore Orlando
vmware-nsx
High
Salvatore Orlando

Bug Description

The pre-delete checks [1] do not take into account DVR interfaces. This means that they will fail to raise an error when deleting a router with DVR interfaces on it, thus causing the router to be removed from the backend and leaving the system in an inconsistent state (as the subsequent db operation will fail)

[1] http://git.openstack.org/cgit/openstack/vmware-nsx/tree/vmware_nsx/neutron/plugins/vmware/plugins/base.py#n1573

Changed in neutron:
assignee: nobody → Salvatore Orlando (salvatore-orlando)

Fix proposed to branch: master
Review: https://review.openstack.org/207010

Changed in vmware-nsx:
status: New → In Progress

Reviewed: https://review.openstack.org/207010
Committed: https://git.openstack.org/cgit/openstack/vmware-nsx/commit/?id=5a07069824d468bc9b49cf72c8d5092d5a8a523f
Submitter: Jenkins
Branch: master

commit 5a07069824d468bc9b49cf72c8d5092d5a8a523f
Author: Salvatore Orlando <email address hidden>
Date: Wed Jul 29 04:42:42 2015 -0700

    NSX-mh: perfrom appropriate pre-delete checks

    This patch ensures that pre-delete checks are executed in the
    appropriate way for both DVR and 'traditional' routers, by
    invoking the _ensure_router_not_in_use method defined in
    neutron.db.l3_db.L3_nat_dbonly_mixin

    Change-Id: I96933c4523bdd90fbc2647f4860533f8d53802e4
    Closes-Bug: #1479309

Changed in vmware-nsx:
status: In Progress → Fix Committed

Reviewed: https://review.openstack.org/219450
Committed: https://git.openstack.org/cgit/openstack/vmware-nsx/commit/?id=4c11c3808625318f38e6c67db18077989fda1928
Submitter: Jenkins
Branch: stable/kilo

commit 4c11c3808625318f38e6c67db18077989fda1928
Author: Salvatore Orlando <email address hidden>
Date: Wed Jul 29 04:42:42 2015 -0700

    NSX-mh: perform appropriate pre-delete checks

    This patch ensures that pre-delete checks are executed in the
    appropriate way for both DVR and 'traditional' routers, by
    invoking the _ensure_router_not_in_use method defined in
    neutron.db.l3_db.L3_nat_dbonly_mixin

    Cherry-picked from commit: 5a07069824d468bc9b49cf72c8d5092d5a8a523f
    Change-Id: I96933c4523bdd90fbc2647f4860533f8d53802e4
    Closes-Bug: #1479309

tags: added: in-stable-kilo

Reviewed: https://review.openstack.org/219458
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=5bc885ddc06d4b7034152e67a36a59a5d5d2d003
Submitter: Jenkins
Branch: stable/juno

commit 5bc885ddc06d4b7034152e67a36a59a5d5d2d003
Author: Salvatore Orlando <email address hidden>
Date: Tue Sep 1 13:49:51 2015 -0700

    NSX-mh: perform appropriate pre-delete checks

    This patch ensures that pre-delete checks are executed in the
    appropriate way for both DVR and 'traditional' routers, by
    invoking the _ensure_router_not_in_use method defined in
    neutron.db.l3_db.L3_nat_dbonly_mixin

    Also, verify metadata network before removing router to ensure
    metada access network's router port is removed if not yet
    deleted.

    Applied from commit: 5a07069824d468bc9b49cf72c8d5092d5a8a523f
    Change-Id: I96933c4523bdd90fbc2647f4860533f8d53802e4
    Closes-Bug: #1479309

This bug is > 240 days without activity. We are unsetting assignee and milestone and setting status to Incomplete in order to allow its expiry in 60 days.

If the bug is still valid, then update the bug status.

Changed in neutron:
assignee: Salvatore Orlando (salvatore-orlando) → nobody
status: New → Incomplete
Changed in neutron:
status: Incomplete → Invalid
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers