Slight incosistency in transport types naming

Bug #1474834 reported by Salvatore Orlando on 2015-07-15
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
vmware-nsx
Low
Salvatore Orlando

Bug Description

For most operations, including plugin configuration, ipsec transport types use an underscore in their syntax: ipsec_gre and ipsec_stt

The underscore is however lost for gateway devices (ipsecgre, ipsecstt).
The names with the underscore should be allowed as well.
The names without the underscore should be kept for bw compatibility.

Tags: mh Edit Tag help

Fix proposed to branch: master
Review: https://review.openstack.org/202089

Changed in python-neutronclient:
assignee: nobody → Salvatore Orlando (salvatore-orlando)
status: New → In Progress

Fix proposed to branch: master
Review: https://review.openstack.org/202097

Changed in vmware-nsx:
status: New → In Progress

Reviewed: https://review.openstack.org/202097
Committed: https://git.openstack.org/cgit/openstack/vmware-nsx/commit/?id=25924649a3586294014f8d6091143f0c8fe73edc
Submitter: Jenkins
Branch: master

commit 25924649a3586294014f8d6091143f0c8fe73edc
Author: Salvatore Orlando <email address hidden>
Date: Wed Jul 15 06:01:21 2015 -0700

    NSX-mh: allow names with underscore for l2gw transport

    This patch:
    1) adds ipsec_stt and ipsec_gre as valid names for l2 gw device
       tranport types. The corresponding names without the underscore
       are anyway still valid
    2) raises an exception if an invalid transport type is specified,
       rather than creating a node without transport connector, as that
       is not the expected behaviour.

    Change-Id: If43b854e553b9cf927a566496cc95b85ae70c414
    Closes-bug: #1474834

Changed in vmware-nsx:
status: In Progress → Fix Committed

Reviewed: https://review.openstack.org/202089
Committed: https://git.openstack.org/cgit/openstack/python-neutronclient/commit/?id=11897cb42c2ba67c8afc1c6791c6c40184689784
Submitter: Jenkins
Branch: master

commit 11897cb42c2ba67c8afc1c6791c6c40184689784
Author: Salvatore Orlando <email address hidden>
Date: Wed Jul 15 05:42:42 2015 -0700

    NSX gateway extension: allow more transport type values

    This patch adds ipsec_gre and ipsec_stt to the list of allowed
    value for the trasnport type option when creating gateway devices.

    Change-Id: Ie48a74a05505db76a7305368793a77789d15f53e
    Partial-Bug: #1474834

Akihiro Motoki (amotoki) wrote :

Salvatore, can we close the bug in neutronclient side?

Changed in python-neutronclient:
importance: Undecided → Low

This bug is > 180 days without activity. We are unsetting assignee and milestone and setting status to Incomplete in order to allow its expiry in 60 days.

If the bug is still valid, then update the bug status.

Changed in python-neutronclient:
assignee: Salvatore Orlando (salvatore-orlando) → nobody
status: In Progress → Incomplete
no longer affects: python-neutronclient
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers