router-interface-add with no address causes internal error

[YAMAMOTO Takashi]

for example:
neutron net-create hoge
neutron port-create --name hoge-port hoge
neutron router-create hoge-router
neutron router-interface-add hoge-router port=hoge-port

this is a regression in commit I7d4e8194815e626f1cfa267f77a3f2475fdfa3d1.

[YAMAMOTO Takashi (yamamoto)]

a proposed fix: https://review.openstack.org/#/c/193440/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/193440
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=c27e66cc7c3427dfbc1e390693c6b0a3e656c783
Submitter: Jenkins
Branch: master

commit c27e66cc7c3427dfbc1e390693c6b0a3e656c783
Author: YAMAMOTO Takashi <email address hidden>
Date: Fri Jun 19 16:28:23 2015 +0900

    Reject router-interface-add with a port which doesn't have any addresses

    Fix a regression in commit I7d4e8194815e626f1cfa267f77a3f2475fdfa3d1 .

    Closes-Bug: #1466750
    Related-Bug: #1439824
    Change-Id: Ic0c4c0adbffe14b1f08d4b2dee91e1dff41cc770

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: feature/pecan
Review: https://review.openstack.org/201131

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/201131
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=3a9975cbc30d9253b96cec9e079b411add184ec1
Submitter: Jenkins
Branch: feature/pecan

commit c27e66cc7c3427dfbc1e390693c6b0a3e656c783
Author: YAMAMOTO Takashi <email address hidden>
Date: Fri Jun 19 16:28:23 2015 +0900

    Reject router-interface-add with a port which doesn't have any addresses

    Fix a regression in commit I7d4e8194815e626f1cfa267f77a3f2475fdfa3d1 .

    Closes-Bug: #1466750
    Related-Bug: #1439824
    Change-Id: Ic0c4c0adbffe14b1f08d4b2dee91e1dff41cc770

commit 83cac810f00933d8b22f17cdcc20094e1d27a018
Author: OpenStack Proposal Bot <email address hidden>
Date: Sat Jul 11 06:09:29 2015 +0000

    Imported Translations from Transifex

    For more information about this automatic import see:
    https://wiki.openstack.org/wiki/Translations/Infrastructure

    Change-Id: I33a9e5a28666a295dd24f6c482b9805b33d0ca69

commit 5b066a237ec0918d882ef2455aef4f2f9cb0606c
Author: Ihar Hrachyshka <email address hidden>
Date: Fri Jul 10 14:07:09 2015 +0200

    Enforce specific order for firewall.(un)filtered_ports and devices

    Lots of tests in the file rely on specific order of devices and ports
    with which they are iterated thru inside firewall implementation. This
    is needed to match a regexp against iptables output generated by the
    firewall driver.

    In production code, those .(un)filtered_ports dictionaries are
    unordered, and it would be not wise to enforce the order for them just
    for the sake of those unit tests.

    Instead, we 'patch' the agent firewall with ordered versions of dict for
    those attributes.

    Also enforce specific order for device_info dictionaries we pass into
    firewall.

    The failure was easily reproducible with PYTHONHASHSEED=111, and after
    the fix, it's gone.

    While at it, stop making assumptions about stable order of dict.values()
    between multiple dictionaries with the same keys. It may actually work
    for now, but it seems fragile. Overall simplified regex construction
    code a bit, f.e. killing some dead or redundant code.

    Closes-Bug: #1473413
    Change-Id: I170087426bc961592b4c4923c64a5fea30d51c21

commit dfbe804994a576994768c95720b4f0ba53e313d7
Author: Dan Prince <email address hidden>
Date: Thu Jul 9 15:31:13 2015 -0400

    get_vif_ports: ignore non-Interface ports

    This patch updates get_vif_ports so that it skips
    ports which aren't in the 'Interfaces' table.

    This fixes an issue where neutron-ovs-cleanup would
    fail if any sort of OVS bond was on the bridge getting
    cleaned up. This is because bonds don't have the same
    attributes as ports, and thus fail subsequent ovs-vsctl
    queries.

    Change-Id: Ic9d30e5916122ce23c5dc8631fbb71115ae8a960
    Closes-bug: #1473179

commit 1025baec55235bf4981872390f1bb65f4e3ae7e6
Author: Wei Wang <email address hidden>
Date: Thu Sep 25 17:49:59 2014 +0800

    Fix duplicate entry catch for allowed address pairs

    If None is submitted as a MAC address in an allowed_address_pair,
 ...

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/208871

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/208871
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=c129bfa48a198c356294af0196bfab9bae187953
Submitter: Jenkins
Branch: stable/kilo

commit c129bfa48a198c356294af0196bfab9bae187953
Author: YAMAMOTO Takashi <email address hidden>
Date: Fri Jun 19 16:28:23 2015 +0900

    Reject router-interface-add with a port which doesn't have any addresses

    Fix a regression in commit I7d4e8194815e626f1cfa267f77a3f2475fdfa3d1 .

    Closes-Bug: #1466750
    Related-Bug: #1439824
    Change-Id: Ic0c4c0adbffe14b1f08d4b2dee91e1dff41cc770
    (cherry picked from commit c27e66cc7c3427dfbc1e390693c6b0a3e656c783)