NSX-mh: Decimal RXTX factor not honoured

Bug #1463363 reported by Salvatore Orlando on 2015-06-09
22
This bug affects 2 people
Affects Status Importance Assigned to Milestone
neutron
Undecided
Unassigned
Juno
Undecided
Unassigned
Kilo
Undecided
Unassigned
vmware-nsx
Undecided
Unassigned

Bug Description

A decimal RXTX factor, which is allowed by nova flavors, is not honoured by the NSX-mh plugin, but simply truncated to integer.

To reproduce:

* Create a neutron queue
* Create a neutron net / subnet using the queue
* Create a new flavor which uses an RXTX factor other than an integer value
* Boot a VM on the net above using the flavor
* View the NSX queue for the VM's VIF -- notice it does not have the RXTX factor applied correctly (for instance if it's 1.2 it does not multiply it at all, if it's 3.4 it applies a RXTX factor of 3)

Fix proposed to branch: master
Review: https://review.openstack.org/189665

Changed in neutron:
assignee: nobody → Salvatore Orlando (salvatore-orlando)
status: New → In Progress

Change abandoned by Salvatore Orlando (<email address hidden>) on branch: master
Review: https://review.openstack.org/189666
Reason: Abandoned in favour of: https://review.openstack.org/#/c/190824/

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/195600

Changed in vmware-nsx:
status: New → Fix Committed

Change abandoned by Salvatore Orlando (<email address hidden>) on branch: stable/juno
Review: https://review.openstack.org/195564
Reason: squashed with https://review.openstack.org/#/c/195601/

Download full text (93.9 KiB)

Reviewed: https://review.openstack.org/196097
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=1cfed745d54a6ce9cb3dd4e6f454666d9e6676c2
Submitter: Jenkins
Branch: feature/qos

commit ba7d673d1ddd5bfa5aa1be5b26a59e9a8cd78a9f
Author: Kevin Benton <email address hidden>
Date: Thu Jun 25 18:31:38 2015 -0700

    Remove duplicated call to setup_coreplugin

    The test case for vlan_transparent was calling setup_coreplugin
    before calling the super setUp method which already calls
    setup_coreplugin. This was causing duplicate core plugin fixtures
    which resulted in patching the dhcp periodic check twice.

    Change-Id: Ide4efad42748e799d8e9c815480c8ffa94b27b38
    Partial-Bug: #1468998

commit e64062efa3b793f7c4ce4ab9e62918af4f1bfcc9
Author: Kevin Benton <email address hidden>
Date: Thu Jun 25 18:29:37 2015 -0700

    Remove double mock of dhcp agent periodic check

    The test case for the periodic check was patching a target
    that the core plugin fixture already patched out. This removes
    that and exposes the mock from the fixture so the test case
    can reference it.

    Change-Id: I3adee6a875c497e070db4198567b52aa16b81ce8
    Partial-Bug: #1468998

commit 25ae0429a713143d42f626dd59ed4514ba25820c
Author: Kevin Benton <email address hidden>
Date: Thu Jun 25 18:24:10 2015 -0700

    Remove double fanout mock

    The test_mech_driver was duplicating a fanout mock already setup
    in the setUp routine.

    Change-Id: I5b88dff13113d55c72241d3d5025791a76672ac2
    Partial-Bug: #1468998

commit 993771556332d9b6bbf7eb3f0300cf9d8a2cb464
Author: Kevin Benton <email address hidden>
Date: Thu Jun 25 17:55:16 2015 -0700

    Remove double callback manager mocks

    setup_test_registry_instance() in the base test case class gives
    each test its own registry by mocking out the get_callback_manager.
    The L3 agent test cases were duplicating this.

    Partial-Bug: #1468998
    Change-Id: I7356daa846524611e9f92365939e8ad15d1e1cd8

commit 0be1efad93734f11cd63fb3b7bd2983442ce1268
Author: Kevin Benton <email address hidden>
Date: Thu Jun 25 16:57:30 2015 -0700

    Remove ensure_dirs double-patch

    test_spawn_radvd called mock.patch on ensure_dirs after the
    setup method already patched it out. This causes issues when
    mock.patch.stopall() is called because the mocks are stored
    as a set and are unwound in a non-deterministic fashion.[1]
    So some of the time they will be undone correctly, but others
    will leave a monkey-patched in mock, causing the ensure_dir
    test to fail.

    1. http://bugs.python.org/issue21239

    Closes-Bug: #1467908
    Change-Id: I321b5fed71dc73bd19b5099311c6f43640726cd4

commit 0a2238e34e72c17ca8a75e36b1f56e41a3ece74e
Author: Sukhdev Kapur <email address hidden>
Date: Thu Jun 25 15:11:28 2015 -0700

    Fix tenant-id in Arista ML2 driver to support HA router

    When HA router is created, the framework creates a network and does
    not specify the tenant-id. This casuse Arista ML2 driver to fail.
    This patch sets the tenant-id when it is not passed explicitly by
    by the network_create() call from the HA r...

tags: added: in-feature-qos

Change abandoned by Kyle Mestery (<email address hidden>) on branch: feature/pecan
Review: https://review.openstack.org/196701
Reason: This is lacking the functional fix [1], so I'll propose a new merge commit which includes that one.

[1] https://review.openstack.org/#/c/196711/

Download full text (171.5 KiB)

Reviewed: https://review.openstack.org/196920
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=7f759c077f8f860c13db92d2ea6b353ef6b70900
Submitter: Jenkins
Branch: feature/pecan

commit 8123144fadd7c5d5e6e56a76ea860512619a2cf6
Author: Moshe Levi <email address hidden>
Date: Sun Jun 28 14:37:14 2015 +0300

    Fix Consolidate sriov agent and driver code

    This patch add mising __init to mech_sriov/mech_driver/
    and update the setup.cfg to the new agent entrypoint

    Trivial Fix

    Change-Id: I53a527081feb78472f496675bbb3c5121d38a14a

commit 8942fccf02e6e179d47582fdb2792a1ca972da21
Author: Assaf Muller <email address hidden>
Date: Mon Jun 29 11:38:51 2015 -0400

    Remove failing SafeFixture tests

    The fixtures 1.3 release attempted to fix the fixtures resource
    leak issue, but failed to do so completely. Our own SafeFixture
    is still needed: The 1.3 release broke our SafeFixture tests,
    but not the usage of SafeFixture itself. This patch removes
    those failing tests for now to unbreak the gate. Jakub reported
    a bug on fixtures 1.3:
    https://bugs.launchpad.net/python-fixtures/+bug/1469759

    We will continue to use SafeFixture until that bug is fixed
    in fixtures, at which point we will be able to require
    fixtures > 1.3.

    Change-Id: I59457c3bb198ff86d5ad55a1e623d008f0034b8f
    Closes-Bug: #1469734

commit 71dffb0a2c1720cd8233a329d32958a0160dd6f5
Author: Kevin Benton <email address hidden>
Date: Mon Jun 29 08:27:41 2015 +0000

    Revert "Removed test_lib module"

    This reverts commit 9a6536de6e1a7fe9b2552adc142e254426b82b6f.

    We pulled all of the plugins out of the tree, many of which still inherit
    from neutron test classes. This change then stated that we no longer
    support testing other plugins. I think this is a bit premature and should
    have been discussed under the subject
    "Neutron plugins can't use neutron plugin unit tests" or something
    similar.

    Change-Id: I68318589f010b731574ea3bfa8df98492bab31fc

commit b20fd81dbd497e058384a0af065dd0f1fdc4c728
Author: Jakub Libosvar <email address hidden>
Date: Fri Jun 5 14:32:51 2015 +0000

    Refactor NetcatTester class

    Following capabilities were added:
       - used transport protocol is passed as a constant instead of bool
       - src port for testing was added
       - connection can be established explicitly
       - change constructor parameters of NetcatTester

    As a part of removing bool for protocol definition
    get_free_namespace_port() was also modified to match the behavior.

    Change-Id: Id2ec322e7f731c05a3754a65411c9a5d8b258126

commit 83e37980dcd0b2bad6d64dd2cb23bcd2891cafca
Author: jingliuqing <email address hidden>
Date: Sat Jun 27 13:41:54 2015 +0800

    Use REST rather than ReST

    Change-Id: I06c9deaab58c5ec13bfeec39fb8fd4b1fe21f42d

commit 1b60df85ba3ad442c2e4e7e52538e1b9a1bf9378
Author: Kevin Benton <email address hidden>
Date: Thu Jun 25 18:34:38 2015 -0700

    Add a double-mock guard to the base test case

    Use mock to patch mock with a check to prevent multiple active
    patches to the...

tags: added: in-feature-pecan

Reviewed: https://review.openstack.org/195561
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=9f74875cf811fc645fce1612cedf918063a6c0a7
Submitter: Jenkins
Branch: stable/kilo

commit 9f74875cf811fc645fce1612cedf918063a6c0a7
Author: Salvatore Orlando <email address hidden>
Date: Tue Jun 9 03:41:07 2015 -0700

    NSX QoS ext: RXTX factor can be decimal

    In Nova flavors it is ok to specify a decimal RXTX factor.
    For this reason when applying QoS to a port Neutron should not
    convert this factor to an integer value, but simply ensure
    it's a valid float number and positive.

    Cherry-picked from commit: 538a7bf3c73d968185590d81a9b3a6523190aeb4
    Partial-Bug: #1463363

    Change-Id: I983123ef7fd8f1b52b358aff3b579459fce63033

tags: added: in-stable-kilo

Reviewed: https://review.openstack.org/195600
Committed: https://git.openstack.org/cgit/openstack/vmware-nsx/commit/?id=2f74499a2880e1006ea0fc1da2b82e3863a281df
Submitter: Jenkins
Branch: stable/kilo

commit 2f74499a2880e1006ea0fc1da2b82e3863a281df
Author: Raghu Katti <email address hidden>
Date: Thu Jun 11 21:25:51 2015 +0000

    Do not convert RXTX factor to int

    Decimal RXTX factors are allowed in nova flavours and
    should be supported by the MH plugin as well.
    This patch drops the conversion to integer but still ensures
    that the resulting maximum bandwidth after applying the RXTX
    factor is still an integer value.

    Closes-Bug: #1463363
    Cherry-picked from commit: 9f61b082093fde7db135f400d7d99724c6c01a43
    Change-Id: I9f5e166e349de0703a8711fa73a127e90059f506

Reviewed: https://review.openstack.org/195601
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=86701a3c7e86454d7c4ec7266f5e9bab1d248ccb
Submitter: Jenkins
Branch: stable/juno

commit 86701a3c7e86454d7c4ec7266f5e9bab1d248ccb
Author: Salvatore Orlando <email address hidden>
Date: Tue Jun 9 03:41:07 2015 -0700

    NSX QoS ext: RXTX factor can be decimal

    In Nova flavors it is ok to specify a decimal RXTX factor.
    For this reason when applying QoS to a port Neutron should not
    convert this factor to an integer value, but simply ensure
    it's a valid float number and positive.

    This patch ialso drops the conversion to integer that happens
    in the NSX-mh plugin but also ensures that the resulting maximum
    bandwidth after applying the RXTX factor is still an integer value.

    Closes-Bug: #1463363
    Patch applied from commit: 9f61b082093fde7db135f400d7d99724c6c01a43
    Change-Id: I9f5e166e349de0703a8711fa73a127e90059f506

tags: added: in-stable-juno

This bug is > 240 days without activity. We are unsetting assignee and milestone and setting status to Incomplete in order to allow its expiry in 60 days.

If the bug is still valid, then update the bug status.

Changed in neutron:
assignee: Salvatore Orlando (salvatore-orlando) → nobody
status: In Progress → Incomplete
Changed in neutron:
status: Incomplete → Invalid
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.