Network gateway vlan connection fails because of int conversion

Bug #1462974 reported by Salvatore Orlando
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Invalid
Undecided
Unassigned
Juno
Fix Released
High
Salvatore Orlando
vmware-nsx
Fix Released
High
Salvatore Orlando

Bug Description

So far there has been an implicit assumption that segmentation_id would be an integer.
In fact, it is a string value, which was been passed down to NSX.

This means that passing a string value, like "xyz", rather than a validation error would have triggered a backend error.
Moreover, the check for validity of the VLAN tag is now in the form min < tag < max, and this does not work unless tag is converted to integer.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to vmware-nsx (master)

Fix proposed to branch: master
Review: https://review.openstack.org/189268

Changed in vmware-nsx:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to vmware-nsx (master)

Reviewed: https://review.openstack.org/189268
Committed: https://git.openstack.org/cgit/openstack/vmware-nsx/commit/?id=e3733b1b894adebcb1e4999a1c50cb6874b77abe
Submitter: Jenkins
Branch: master

commit e3733b1b894adebcb1e4999a1c50cb6874b77abe
Author: vmware_nsx_ci <email address hidden>
Date: Mon Jun 8 04:23:43 2015 -0700

    NSX-mh: fix default l2 gw connections

    This patch fixes connections to the default layer-2 gateway
    ensuring that:
    1) no "None" value is sent for tags to nsxlib. In particular this
       patch ensures that the tenant_id is populated when the request
       is sent with admin credentials.
    2) the segmentation_id attribute is converted to integer before
       validating whether it's a valid VLAN tag.

    Change-Id: I959edab036c32a3a2cfdbe4d7567daf29dc75797
    Closes-Bug: #1462973
    Closes-Bug: #1462974

Changed in vmware-nsx:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to vmware-nsx (stable/kilo)

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/195579

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to vmware-nsx (stable/kilo)

Reviewed: https://review.openstack.org/195579
Committed: https://git.openstack.org/cgit/openstack/vmware-nsx/commit/?id=d664c41c18718ee20d25be2a33140b8c5f85c007
Submitter: Jenkins
Branch: stable/kilo

commit d664c41c18718ee20d25be2a33140b8c5f85c007
Author: Salvatore Orlando <email address hidden>
Date: Thu Jun 25 06:34:37 2015 -0700

    NSX-mh: fix default l2 gw connections

    This patch fixes connections to the default layer-2 gateway
    ensuring that:
    1) no "None" value is sent for tags to nsxlib. In particular this
       patch ensures that the tenant_id is populated when the request
       is sent with admin credentials.
    2) the segmentation_id attribute is converted to integer before
       validating whether it's a valid VLAN tag.

    Cherry-picked from commit: e3733b1b894adebcb1e4999a1c50cb6874b77abe
    Change-Id: I959edab036c32a3a2cfdbe4d7567daf29dc75797
    Closes-Bug: #1462973
    Closes-Bug: #1462974

tags: added: in-stable-kilo
Alan Pevec (apevec)
Changed in neutron:
status: New → Invalid
Adit Sarfaty (asarfaty)
Changed in vmware-nsx:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.