vmware unit tests broken

Bug #1416596 reported by Salvatore Orlando on 2015-01-31
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Medium
Salvatore Orlando
vmware-nsx
Undecided
Salvatore Orlando

Bug Description

commit 79c97120de9cff4d0992b5d41ff4bbf05e890f89 introduced a constraint which causes a vmware unit test to fail.
This unit test indeed directly exercises the plugin - creating a context with get_admin_context. For such context, tenant_id is None, and the DB constraint on the default security group table fails.

Reviewed: https://review.openstack.org/151839
Committed: https://git.openstack.org/cgit/stackforge/vmware-nsx/commit/?id=85dcc08c9fce5df62d6cbb37cf0f6a4cb064829c
Submitter: Jenkins
Branch: master

commit 85dcc08c9fce5df62d6cbb37cf0f6a4cb064829c
Author: Salvatore Orlando <email address hidden>
Date: Fri Jan 30 18:08:46 2015 -0800

    vmware unit tests: tenant_id must be in neutron ctx

    Fix a unit test which previousluy passed a context without
    a tenant identifier to the plugin. This triggered a database
    constraint failure in the default security group table.

    Change-Id: I800af3dcdc9f2ebce16f6c942706a41f7ce8e889
    Closes-Bug: #1416596

Changed in vmware-nsx:
status: New → Fix Committed
Changed in vmware-nsx:
assignee: nobody → Salvatore Orlando (salvatore-orlando)

Fix proposed to branch: master
Review: https://review.openstack.org/151928

Changed in neutron:
status: New → In Progress
Kyle Mestery (mestery) on 2015-02-03
Changed in neutron:
importance: Undecided → Medium
Kyle Mestery (mestery) on 2015-02-04
Changed in neutron:
milestone: kilo-2 → kilo-3

Reviewed: https://review.openstack.org/151928
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=568f3562ae540a2eb5d6784d43f92786084d34f6
Submitter: Jenkins
Branch: master

commit 568f3562ae540a2eb5d6784d43f92786084d34f6
Author: Salvatore Orlando <email address hidden>
Date: Sat Jan 31 23:49:38 2015 -0800

    Restore and fix vmware unit tests

    This patch actually restores vmware unit tests, by adding back
    the __init__.py file which was renamed during the advanced
    service spinoff and not reinstated when fixing vmware code to
    comply with the spinoff.

    Furthermore, this patch also fixes a minor issue with context
    usage in vmware unit tests which is triggering failures because
    of the new database constraint introduced with the commit
    79c97120de9cff4d0992b5d41ff4bbf05e890f89

    Finally, flake8 tests on vmware directories are also restored
    with this patch.

    Change-Id: Ib63463fca28bbb4a1eb60b8f5f4b63b3d3367c9e
    Closes-Bug: #1416593
    Closes-Bug: #1416596

Changed in neutron:
status: In Progress → Fix Committed
Thierry Carrez (ttx) on 2015-03-19
Changed in neutron:
status: Fix Committed → Fix Released
Thierry Carrez (ttx) on 2015-04-30
Changed in neutron:
milestone: kilo-3 → 2015.1.0
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers