Incorrect check for security groups in create_port

Bug #1405311 reported by Salvatore Orlando on 2014-12-24
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Critical
Salvatore Orlando
vmware-nsx
Critical
Salvatore Orlando

Bug Description

The check will fail if security groups in the request body are an empty string.

In http://git.openstack.org/cgit/stackforge/vmware-nsx/tree/vmware_nsx/neutron/plugins/vmware/plugins/base.py#n1127 the code should not raise if security groups are an empty list

This causes tempest's smoke and full test suites to fail always

Targeting also neutron because due to the critical nature of this bug - a show stopper for CI - the fix should be pushed into the main repo's master branch as well.

Changed in neutron:
importance: Undecided → Critical
milestone: none → kilo-2
assignee: nobody → Salvatore Orlando (salvatore-orlando)

Fix proposed to branch: master
Review: https://review.openstack.org/143751

Changed in neutron:
status: New → In Progress

Fix proposed to branch: master
Review: https://review.openstack.org/143752

Changed in vmware-nsx:
status: New → In Progress

Reviewed: https://review.openstack.org/143752
Committed: https://git.openstack.org/cgit/stackforge/vmware-nsx/commit/?id=eb52e853c4e3a3b5b0378929d8c43905c99486ad
Submitter: Jenkins
Branch: master

commit eb52e853c4e3a3b5b0378929d8c43905c99486ad
Author: Salvatore <email address hidden>
Date: Wed Dec 24 01:23:41 2014 +0100

    VMware: fix security group check on port create

    The code did not consider an empty list among the cases
    in which security groups are not supplied on port create.

    Change-Id: I6e4ac3dee0d02c6c26977f8e2fee717587b8bfc5
    Closes-Bug: #1405311

Changed in vmware-nsx:
status: In Progress → Fix Committed

Reviewed: https://review.openstack.org/143751
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=f854cf3af9ec895fa3e368af7c57c7548cf0bc5b
Submitter: Jenkins
Branch: master

commit f854cf3af9ec895fa3e368af7c57c7548cf0bc5b
Author: Salvatore <email address hidden>
Date: Wed Dec 24 01:17:17 2014 +0100

    VMware: fix security group check on port create

    The code did not consider an empty list among the cases
    in which security groups are not supplied on port create.

    Change-Id: I325cce2165d2ec683ecac3cabdbfb80a03b288c9
    Closes-Bug: #1405311

Changed in neutron:
status: In Progress → Fix Committed
tags: added: sg-fw
Thierry Carrez (ttx) on 2015-02-05
Changed in neutron:
status: Fix Committed → Fix Released
Thierry Carrez (ttx) on 2015-04-30
Changed in neutron:
milestone: kilo-2 → 2015.1.0
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers