neutron

pretty_tox unnecessarily uses bash

Bug #1398266 reported by YAMAMOTO Takashi
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Undecided
YAMAMOTO Takashi
neutron 2015.1.0 "kilo"

Bug Description

A recent change (commit 0d5a11d9c722870f9c5e31a993219c7e240b4e19)
introduced bash dependency for something which can be easily done without using bash specific feature.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/138251

Changed in neutron:
assignee: nobody → YAMAMOTO Takashi (yamamoto)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to neutron (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/138650

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/138251
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=828afa4afa53fc44d1547ac4af16a7f99bd5cd09
Submitter: Jenkins
Branch: master

commit 828afa4afa53fc44d1547ac4af16a7f99bd5cd09
Author: YAMAMOTO Takashi <email address hidden>
Date: Tue Dec 2 13:18:48 2014 +0900

    pretty_tox.sh: Portablity improvement

    A recent change (commit 0d5a11d9c722870f9c5e31a993219c7e240b4e19)
    introduced bash dependency. It broke my environment, where bash
    is not available. This change aims to restore it.

    As far as I undestand, the change in question requires bash for
    the "pipefail" feature. Fortunately there's a more portable
    well-known trick for the purpose.

    Closes-Bug: #1398266
    Change-Id: Id3561d81462923d20ad39584ba4cf8e1a294a8a8

Changed in neutron:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to neutron (master)

Reviewed: https://review.openstack.org/138650
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=846ae08d877ea4537dcc706ecf8d1dbf3cc9bfc7
Submitter: Jenkins
Branch: master

commit 846ae08d877ea4537dcc706ecf8d1dbf3cc9bfc7
Author: YAMAMOTO Takashi <email address hidden>
Date: Wed Dec 3 15:29:02 2014 +0900

    tox.ini: Prevent casual addition of bash dependency

    While bash is not available on every environments, there seems to be
    a tendency to introduce more bash dependency very casually. This check
    is intended to be a reminder to give people a chance to consider
    alternatives.

    Related-Bug: #1398266
    Change-Id: I5103e0d7c111880d9a02dd93de56c567066ed14c

Thierry Carrez (ttx)
Changed in neutron:
milestone: none → kilo-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: kilo-1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.