NetScaler LBaaS Driver: Fails to distinguish between SSL and other errors

Bug #1360970 reported by Angus Lees
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Medium
Angus Lees

Bug Description

Netscaler client code has an incorrect exception handling order, resulting in the SSLError case never being invoked:

neutron.services.loadbalancer.drivers.netscaler.ncc_client.NSClient._execute_request has a list of exception handlers to log various types of errors with more specific error messages. Unfortunately, it catches requests.exceptions.ConnectionError before requests.exceptions.SSLError, but ConnectionError is a superclass of SSLError so the latter is never invoked.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/116539

Changed in neutron:
assignee: nobody → Angus Lees (gus)
status: New → In Progress
Kyle Mestery (mestery)
Changed in neutron:
milestone: none → juno-3
importance: Undecided → Medium
Thierry Carrez (ttx)
Changed in neutron:
milestone: juno-3 → juno-rc1
Revision history for this message
Kyle Mestery (mestery) wrote :

Moving medium priority bug out of Juno-RC1.

Changed in neutron:
milestone: juno-rc1 → kilo-1
Revision history for this message
Kyle Mestery (mestery) wrote :

Per my own confusion, moving back to Juno-RC1.

Changed in neutron:
milestone: kilo-1 → juno-rc1
Kyle Mestery (mestery)
Changed in neutron:
milestone: juno-rc1 → none
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/116539
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=b0d763e92218391aae51b205f303a4d6712d87d7
Submitter: Jenkins
Branch: master

commit b0d763e92218391aae51b205f303a4d6712d87d7
Author: Angus Lees <email address hidden>
Date: Mon Aug 25 12:02:16 2014 +1000

    Fix incorrect exception order in _execute_request

    _execute_request has a list of exception handlers to log various types
    of errors with more specific error messages. Unfortunately, it catches
    requests.exceptions.ConnectionError before requests.exceptions.SSLError,
    but ConnectionError is a superclass of SSLError so the latter is never
    invoked.

    This change corrects the exception handling order, and enables the
    bad-except-order pylint check now that the check passes.

    Change-Id: I92bacd6088de5cbc170bc5c081a1db1baeec69e7
    Closes-Bug: #1360970

Changed in neutron:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in neutron:
milestone: none → kilo-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: kilo-1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.