NetScaler LBaaS Driver: Fails to distinguish between SSL and other errors

[Angus Lees]

Netscaler client code has an incorrect exception handling order, resulting in the SSLError case never being invoked:

neutron.services.loadbalancer.drivers.netscaler.ncc_client.NSClient._execute_request has a list of exception handlers to log various types of errors with more specific error messages. Unfortunately, it catches requests.exceptions.ConnectionError before requests.exceptions.SSLError, but ConnectionError is a superclass of SSLError so the latter is never invoked.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/116539

[Kyle Mestery (mestery)]

Moving medium priority bug out of Juno-RC1.

[Kyle Mestery (mestery)]

Per my own confusion, moving back to Juno-RC1.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/116539
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=b0d763e92218391aae51b205f303a4d6712d87d7
Submitter: Jenkins
Branch: master

commit b0d763e92218391aae51b205f303a4d6712d87d7
Author: Angus Lees <email address hidden>
Date: Mon Aug 25 12:02:16 2014 +1000

    Fix incorrect exception order in _execute_request

    _execute_request has a list of exception handlers to log various types
    of errors with more specific error messages. Unfortunately, it catches
    requests.exceptions.ConnectionError before requests.exceptions.SSLError,
    but ConnectionError is a superclass of SSLError so the latter is never
    invoked.

    This change corrects the exception handling order, and enables the
    bad-except-order pylint check now that the check passes.

    Change-Id: I92bacd6088de5cbc170bc5c081a1db1baeec69e7
    Closes-Bug: #1360970