NSX: missing fk constraint between network gateway and devices

[Salvatore Orlando]

https://github.com/openstack/neutron/blob/master/neutron/plugins/vmware/dbexts/networkgw_db.py#L120

class NetworkGatewayDeviceReference(model_base.BASEV2):
    id = sa.Column(sa.String(36), primary_key=True)
    network_gateway_id = sa.Column(sa.String(36),
                                   sa.ForeignKey('networkgateways.id',
                                                 ondelete='CASCADE'),
                                   primary_key=True)
    interface_name = sa.Column(sa.String(64), primary_key=True)

The field 'id' refers to a gateway device. As there is no foreign key constraint the database layer will allow for creating gateway for non-existing devices - the error will then be detected in the backend anyway, but it should be caught at the DB layer.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/93826

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/118148

[Kyle Mestery (mestery)]

Moving medium priority bug out of Juno-RC1.

[Kyle Mestery (mestery)]

Per my own confusion, moving back to Juno-RC1.

[Kyle Mestery (mestery)]

Since we hope to cut the RC1 release on Monday/Tuesday, moving this out for now. If we have an RC2, I'm fine with adding this back on the radar if we need to.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/118148
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=906055b07771c816a3bb2954fbfbd89fafe2ab4f
Submitter: Jenkins
Branch: master

commit 906055b07771c816a3bb2954fbfbd89fafe2ab4f
Author: Salvatore <email address hidden>
Date: Mon Sep 1 14:37:00 2014 +0200

    NSX: Validate gateway device list against DB

    This patch adds a check for validating the devices for a network
    gateway are defined in the neutron DB before the request for
    creating the network gateway is sent to the NSX backend.

    Change-Id: Ic2245f965da332dbaee4ab5a869ce47f06a9e6ce
    Partial-Bug: #1319581

[OpenStack Infra (hudson-openstack)]

Change abandoned by Kyle Mestery (<email address hidden>) on branch: master
Review: https://review.openstack.org/93826
Reason: This review is > 4 weeks without comment and currently blocked by a core reviewer with a -2. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and contacting the reviewer with the -2 on this review to ensure you address their concerns.