NSX: sync do not pass around model object

Bug #1281772 reported by Aaron Rosen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
VMwareAPI-Team
Fix Released
High
Unassigned
neutron
Fix Released
High
Aaron Rosen
Havana
Fix Released
High
Aaron Rosen

Bug Description

The NSX sync backend previously passed around a sqlalchemy model object
around which was nice because we did not need to query the database an
additional time to update the status of an object. Unfortinately, this
was add done within a db transaction which included a call to NSX which
could cause deadlock this needed to be removed.

Aaron Rosen (arosen)
Changed in neutron:
assignee: nobody → Aaron Rosen (arosen)
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/74508

Changed in neutron:
status: New → In Progress
Aaron Rosen (arosen)
tags: added: nvp
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/74508
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=084b7f62280241a9037b6f9e592c466135e5fec1
Submitter: Jenkins
Branch: master

commit 084b7f62280241a9037b6f9e592c466135e5fec1
Author: Aaron Rosen <email address hidden>
Date: Tue Feb 18 12:22:42 2014 -0800

    NSX: Sync do not pass around model object

    The NSX sync backend previously passed around a sqlalchemy model object
    around which was nice because we did not need to query the database an
    additional time to update the status of an object.

    Unfortunately, this was add done within a db transaction which included a
    call to NSX which could cause deadlock this needed to be removed. Now a
    dict is passed around instead and proper transaction handling
    is used when updating objects.

    Change-Id: Id50abd8f2143b127d1ca81c360c1c6d400e1d74f
    Closes-bug: #1281772

Changed in neutron:
status: In Progress → Fix Committed
Akihiro Motoki (amotoki)
Changed in neutron:
milestone: none → icehouse-rc1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/havana)

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/82887

Aaron Rosen (arosen)
tags: added: havana-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/82928

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/havana)

Reviewed: https://review.openstack.org/82887
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=5ccfeae5801189be8e3546d1aa52840b1e3bd0bb
Submitter: Jenkins
Branch: stable/havana

commit 5ccfeae5801189be8e3546d1aa52840b1e3bd0bb
Author: Aaron Rosen <email address hidden>
Date: Tue Feb 18 12:22:42 2014 -0800

    NSX: Sync do not pass around model object

    The NSX sync backend previously passed around a sqlalchemy model object
    around which was nice because we did not need to query the database an
    additional time to update the status of an object.

    Unfortunately, this was add done within a db transaction which included a
    call to NSX which could cause deadlock this needed to be removed. Now a
    dict is passed around instead and proper transaction handling
    is used when updating objects.

    Closes-bug: #1281772

    Conflicts:
     neutron/plugins/nicira/common/sync.py

    Change-Id: Id50abd8f2143b127d1ca81c360c1c6d400e1d74f
    (cherry picked from commit 084b7f62280241a9037b6f9e592c466135e5fec1)

tags: added: in-stable-havana
Thierry Carrez (ttx)
Changed in neutron:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: icehouse-rc1 → 2014.1
Tracy Jones (tjones-i)
Changed in openstack-vmwareapi-team:
status: New → Fix Released
importance: Undecided → High
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.