Remove unused imports

Bug #1265267 reported by Wu Wenxiang
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Undecided
Wu Wenxiang

Bug Description

************* Module neutron.plugins.plumgrid.plumgrid_plugin.plumgrid_plugin
W: 33, 0: Unused import quota_db (unused-import)
--
************* Module neutron.plugins.metaplugin.meta_neutron_plugin
W: 30, 0: Unused import config (unused-import)
--
************* Module neutron.plugins.nec.db.api
W: 27, 0: Unused import config (unused-import)
--
************* Module neutron.plugins.nec.nec_plugin
W: 36, 0: Unused import quota_db (unused-import)
--
************* Module neutron.plugins.nec.common.config
W: 21, 0: Unused import rpc (unused-import)
--
************* Module neutron.plugins.ryu.ryu_neutron_plugin
W: 43, 0: Unused import config (unused-import)
--
************* Module neutron.plugins.ryu.agent.ryu_neutron_agent
W: 46, 0: Unused import config (unused-import)
--
************* Module neutron.plugins.midonet.plugin
W: 51, 0: Unused import config (unused-import)
--
************* Module neutron.plugins.midonet.agent.midonet_driver
W: 24, 0: Unused import config (unused-import)
--
************* Module neutron.plugins.mlnx.db.mlnx_db_v2
W: 26, 0: Unused import config (unused-import)
--
************* Module neutron.plugins.mlnx.agent.eswitch_neutron_agent
W: 39, 0: Unused import config (unused-import)
--
************* Module neutron.plugins.mlnx.common.comm_utils
W: 23, 0: Unused import config (unused-import)
--
************* Module neutron.plugins.mlnx.mlnx_plugin
W: 37, 0: Unused import quota_db (unused-import)
--
************* Module neutron.plugins.hyperv.hyperv_neutron_plugin
W: 29, 0: Unused import quota_db (unused-import)
--
************* Module neutron.plugins.nicira.check_nvp_config
W: 28, 0: Unused import nvp_cfg (unused-import)
************* Module neutron.plugins.nicira.NeutronServicePlugin
W: 32, 0: Unused import config (unused-import)
--
************* Module neutron.plugins.nicira.vshield.vcns_driver
W: 22, 0: Unused import nicira_cfg (unused-import)
--
************* Module neutron.plugins.nicira.NeutronPlugin
W: 48, 0: Unused import quota_db (unused-import)
W: 62, 0: Unused import config (unused-import)
--
************* Module neutron.plugins.ml2.plugin
W: 31, 0: Unused import quota_db (unused-import)
W: 46, 0: Unused import config (unused-import)
--
************* Module neutron.plugins.ml2.drivers.mech_arista.mechanism_arista
W: 26, 0: Unused import config (unused-import)
--
************* Module neutron.plugins.ml2.drivers.l2pop.mech_driver
W: 27, 0: Unused import config (unused-import)
--
************* Module neutron.plugins.ml2.drivers.cisco.network_db_v2
W: 24, 0: Unused import nexus_models_v2 (unused-import)
--
************* Module neutron.plugins.linuxbridge.db.l2network_db_v2
W: 25, 0: Unused import config (unused-import)
--
************* Module neutron.plugins.linuxbridge.lb_neutron_plugin
W: 40, 0: Unused import quota_db (unused-import)
--
************* Module neutron.plugins.linuxbridge.agent.linuxbridge_neutron_agent
W: 50, 0: Unused import config (unused-import)
--
************* Module neutron.plugins.openvswitch.agent.ovs_neutron_agent
W: 51, 0: Unused import config (unused-import)
--
************* Module neutron.plugins.openvswitch.ovs_neutron_plugin
W: 49, 0: Unused import quota_db (unused-import)
W: 62, 0: Unused import config (unused-import)
--
************* Module neutron.plugins.embrane.base_plugin
W: 33, 0: Unused import config (unused-import)
--
************* Module neutron.plugins.cisco.db.network_db_v2
W: 29, 0: Unused import nexus_models_v2 (unused-import)
--
************* Module neutron.tests.unit.nec.test_db
W: 25, 0: Unused import nmodels (unused-import)
--
************* Module neutron.tests.unit.nec.test_security_group
W: 25, 0: Unused import ndb (unused-import)
--
************* Module neutron.tests.unit.nec.test_ofc_manager
W: 24, 0: Unused import nmodels (unused-import)
--
************* Module neutron.tests.unit.ryu.test_defaults
W: 20, 0: Unused import config (unused-import)
--
************* Module neutron.tests.unit.ryu.test_ryu_plugin
W: 19, 0: Unused import ryu_models_v2 (unused-import)
--
************* Module neutron.tests.unit.ryu.test_ryu_db
W: 24, 0: Unused import ryu_models_v2 (unused-import)
W: 22, 0: Unused import config (unused-import)
--
************* Module neutron.tests.unit.mlnx.test_defaults
W: 19, 0: Unused import config (unused-import)
--
************* Module neutron.tests.unit.mlnx.test_mlnx_comm_utils
W: 20, 0: Unused import config (unused-import)
--
************* Module neutron.tests.unit.nicira.test_nvplib
W: 25, 0: Unused import config (unused-import)
--
************* Module neutron.tests.unit.openvswitch.test_ovs_defaults
W: 18, 0: Unused import config (unused-import)
--
************* Module neutron.tests.unit.embrane.test_embrane_l3_plugin
W: 26, 0: Unused import config (unused-import)
************* Module neutron.tests.unit.embrane.test_embrane_defaults
W: 25, 0: Unused import config (unused-import)
************* Module neutron.tests.unit.embrane.test_embrane_neutron_plugin
W: 26, 0: Unused import config (unused-import)
--
************* Module install_venv
W: 29, 0: Unused import subprocess (unused-import)

Changed in neutron:
assignee: nobody → Wu Wenxiang (wu-wenxiang)
status: New → In Progress
Revision history for this message
Akihiro Motoki (amotoki) wrote :

some imports with "# noqa" are REQUIRED and they cannot be removed to make sure Neutron works.
At least we CANNOT remove "import quota_db" to make sure DbQuota driver works correctly. It is required to load quota db models although it is not referred to in each file.

I haven't checked all imports, but you need to check why they are imported now carefully.

Please clarify which imports you are going to remove before submitting a patch.

Changed in neutron:
status: In Progress → Incomplete
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/64605

Changed in neutron:
status: Incomplete → In Progress
Revision history for this message
Wu Wenxiang (wu-wenxiang) wrote :

Only modify unused import subprocess in tools/install-venv

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/64605
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=ab97446132da9b0aff4d13ac01591f86aa066d48
Submitter: Jenkins
Branch: master

commit ab97446132da9b0aff4d13ac01591f86aa066d48
Author: Wu Wenxiang <wu.wenxiang@99cloud.net>
Date: Wed Jan 1 21:59:07 2014 +0800

    Remove unused imports

    Remove unused imports in tools/install_venv.py

    Change-Id: Ia2fbb4ece5c8bcdee96503f0f853f826ae4f3dfa
    Closes-Bug: #1265267

Changed in neutron:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in neutron:
milestone: none → icehouse-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: icehouse-2 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.