Performance problem in FunctionEvaluator

[Steve Rogers]

FunctionEvaluator calls the evaluate method on the Evaluator 3 times, once to check for null, once for logging and once to return the data.
Should only call this once
Currently
if(evaluator.evaluate(t) == null) {
                ValidationRuntimeException vre = new ValidationRuntimeException("evaluator evaluates to null");
                logger.throwing("FunctionEvaluator", "evaluate", vre);
                throw vre;
}

Method m = evaluator.evaluate(t).getClass().getMethod(methodName, argTypes);
X result = (X) m.invoke(evaluator.evaluate(t), args);

Could be
X evaluatedResult = evaluator.evaluate(t);
if(evaluatedResult == null) {
                ValidationRuntimeException vre = new ValidationRuntimeException("evaluator evaluates to null");
                logger.throwing("FunctionEvaluator", "evaluate", vre);
                throw vre;
}

Method m = evaluatedResult.getClass().getMethod(methodName, argTypes);
X result = (X) m.invoke(evaluatedResult, args);

[fivemile (fivemilesolutions)]

Accepted bug

[fivemile (fivemilesolutions)]

Commited to v1.1 revision 21