fix virtualbox support

Bug #683614 reported by j^
20
This bug affects 4 people
Affects Status Importance Assigned to Milestone
VMBuilder
In Progress
Undecided
Unassigned

Bug Description

VMBuilder/plugins/virtualbox/vm.py is not in sync with current plugin api, deploy now takes an extra argument destdir.

Revision history for this message
j^ (j) wrote :
Revision history for this message
j^ (j) wrote :

looks like more whats needed to get virtualbox support working.
attached patch makes creating vbox images work

summary: - virtualbox deploy not accepting destdir argument
+ fix virtualbox support
Revision history for this message
Evan Felix (karcaw) wrote :

if you have the new virtualbox 4.0, the deploy script needs to drop the 'VBoxManage openmedium' section.

Also I found i needed to tweak the deploy for specifying mac addresses, as vmbuild expects colons in the mac, but VBoxManage does not want them:

from vm_deploy_script.tmpl:
VBoxManage modifyvm $vm_name --macaddress1 $mac.replace(":","")

Revision history for this message
Michael Vogt (mvo) wrote :

Thanks for your bugreport and your patch.

A fix for this got added in revision http://bazaar.launchpad.net/~vmbuilder-dev/vmbuilder/0.12/revision/469
Could you please check if more is required or if that fixes the problem. if more is required a updated patch would be appreciated.

Thanks,
 Michael

Changed in vmbuilder:
status: New → In Progress
Revision history for this message
j^ (j) wrote :

in ubuntu 10.11 i get

Traceback (most recent call last):
  File "/usr/bin/vmbuilder", line 24, in <module>
    cli.main()
  File "/usr/lib/python2.7/dist-packages/VMBuilder/contrib/cli.py", line 227, in main
    hypervisor.finalise(destdir)
  File "/usr/lib/python2.7/dist-packages/VMBuilder/hypervisor.py", line 79, in finalise
    self.call_hooks('deploy', destdir)
  File "/usr/lib/python2.7/dist-packages/VMBuilder/distro.py", line 67, in call_hooks
    call_hooks(self, *args, **kwargs)
  File "/usr/lib/python2.7/dist-packages/VMBuilder/util.py", line 165, in call_hooks
    getattr(context, func, log_no_such_method)(*args, **kwargs)
  File "/usr/lib/python2.7/dist-packages/VMBuilder/plugins/virtualbox/vm.py", line 50, in deploy
    vm_deploy_script = VMBuilder.util.render_template('virtualbox', self.context, 'vm_deploy_script', { 'os_type' : self.context.distro.__class__.__name__, 'vm_name' : hostname, 'vm_disks' : self.imgs, 'memory' : self.context.get_setting('mem'), 'cpus' : self.context.get_setting('cpus') })
  File "/usr/lib/python2.7/dist-packages/VMBuilder/util.py", line 147, in render_template
    output = t.respond()
  File "_etc_vmbuilder_virtualbox_vm_deploy_script_tmpl.py", line 166, in respond
NameMapper.NotFound: cannot find 'mac'

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.