vm-attach-message does not prompt for message number

[Uday Reddy]

Alan Wehmann reports (2012-02-10, private email):

To investigate further the behaviour that I reported earlier for
"vm-attach-message" in VM 8.2.0b1 I switched back and forth between
that and VM 8.1.1, by switching between the following two lines in my
initialization file:

I noted that with VM 8.1.1 I did get asked for a message number; with
VM 8.2.0b1 I did not get asked for a message number.

I was also asked for a folder in both cases, because I didn't have a
parent defined.

[Uday Reddy (reddyuday)]

Alan Wehmann continues:

I've been stepping through execution of VM 8.2.0b1 function
"vm-attach-message" with edebug. I've also done the same with the VM
8.1.1 function "vm-mime-attach-message".

In VM 8.2.0b1 function "vm-attach-message" the "(interactive" clause
contains a "(cond" structure & both clauses in that have the clause

(setq mlist (vm-select-operable-messages 1 t "Attach"))

While stepping, I note that this clause gives a non-null value to
mlist and that means that the following "(when (null mlist)" isn't
satisfied and I don't get asked for a message number.

Equivalent logic in the VM 8.1.1 function "vm-mime-attach-message" has

(setq mlist (vm-select-marked-or-prefixed-messages 0))

and when stepping through that, mlist is returned as nil and the test
"(if (null mlist)" is successful and I get asked for a message
number.

[Uday Reddy (reddyuday)]

Yeah, it was my fault. When I did the global renaming of `vm-select-marked-or-prefixed-messages' to `vm-select-operable-messages', I noticed that 0 messages were being selected here. It didn't make sense to me. So, I changed it to 1.

There were apparently subtle interactions in the code, which I will go back and fix now.

Thanks for identifying the issue!

Cheers,
Uday