wrong-type argument in vm-fill-long-lines-in-reply

[Uday Reddy]

Matthew Lovell reports (viewmail-bugs, 2012-01-04):

I've setup vm-reply-hook to fill paragraphs in replies prior to my
editing them. This configuration is copied from my previous vm
setup, under xemacs.

(add-hook 'vm-reply-hook 'vm-fill-long-lines-in-reply)

I can also get the identical error to occur by interactively calling
vm-fill-long-lines-in-reply in the composition frame of the reply.

Debugger entered--Lisp error: (wrong-type-argument number-or-marker-p nil)
  vm-forward-paragraph()
  ad-Orig-vm-fill-paragraphs-containing-long-lines(nil 435 679)
  vm-fill-paragraphs-containing-long-lines(nil 435 679)
  vm-fill-long-lines-in-reply()
  run-hooks(vm-reply-hook)
  vm-do-reply(nil t 1)
  vm-reply-include-text(1)
  call-interactively(vm-reply-include-text nil nil)

[Uday Reddy (reddyuday)]

> I've setup vm-reply-hook to fill paragraphs in replies prior to my
> editing them. This configuration is copied from my previous vm
> setup, under xemacs.
>
> (add-hook 'vm-reply-hook 'vm-fill-long-lines-in-reply)

Please note that you don't need to do this. Once you have set the variable
I mentioned (vm-fill-paragraphs-containing-long-lines-in-reply) to a non-nil value, VM will invoke filling automatically.

> I can also get the identical error to occur by interactively calling
> vm-fill-long-lines-in-reply in the composition frame of the reply.

I think it is a good idea to allow the interactive use of this command. So,
I will add a check for the variable.

However, I think it is not a good idea to do automatic filling any more.
You can turn on auto-fill-mode in the message composition buffer. If there
are still long lines when you send, then VM will MIME-encode the message so
that it is legal and the email recipients can use their own viewers to do
filling or wrapping.

The problem with automatic filling is that it removes line breaks which may
be important, e.g., in tables or program code.

[Uday Reddy (reddyuday)]

Fix committed in rev. 1325.