Autoload generation fails with emacs 21

[Göran Uddeborg]

Doing an installation of vm 8.1.1 on an emacs 21 system, the build failed when creating vm-autoloads.el. I believe I tracked this down to the end of the vm-build.el file, where this code is found:

      (if (>= emacs-major-version 22)
          (update-autoloads-from-directories source-dir)
 (if (>= emacs-major-version 21)
            (update-directory-autoloads source-dir)
          (error "Do not know how to generate autoloads"))))))

That is, for emacs 22 and later, update-autoloads-from-directories is used. For emacs 21, update-directory-autoloads is used. But that seems to be the wrong way around. In emacs 21 I have update-autoloads-from-directories available but not update-directory-autoloads. And looking at the documentation of update-directory-autoloads in emacs 23 it says

    update-autoloads-from-directories is an alias for
    `update-directory-autoloads'.

    (update-autoloads-from-directories &rest DIRS)

    This function is obsolete since 22.1;
    use `update-directory-autoloads' instead.

So it does seem like the branches in the test are the wrong way around.

[Uday Reddy (reddyuday)]

Hi Goeran, this was fixed but unfortunately the fix was applied to the
trunk rather than the 8.1.x branch. Would you like to switch to
8.1.93a release? It is quite stable and I am thinking of the next
releast to be a beta.

Cheers,
Uday

[Göran Uddeborg (goeran-uddeborg)]

With a trivial fix, I am using 8.1.1 now despite this problem. But yes, I could probably do a bit of beta testing again. I'll switch to 8.1.9* shortly.

[Uday Reddy (reddyuday)]

Goeran, is this working with the 8.2.0b release? Do we need to do anything more?

[Göran Uddeborg (goeran-uddeborg)]

It's probably ok. I've been running a version I checked out from bzr some time ago, and that works without local modifications. But let me try it out with 8.2.0b too to make sure there hasn't been any regression. I'll be back shortly.

[Göran Uddeborg (goeran-uddeborg)]

It doesn't happen with 8.2.0b either. Feel free to close this issue.