make-extent problem with elp

Bug #594856 reported by Uday Reddy on 2010-06-15
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Uday Reddy

Bug Description

When the profiling tool elp is turned on, one gets an error about make-extent being undefined in Gnu Emacs. Not clear why this is. The error disappears when elp is turned off.

Related branches

Uday Reddy (reddyuday) on 2010-06-15
Changed in vm:
assignee: nobody → Uday Reddy (reddyuday)
Tim Cross (tcross) wrote :

I think the problem is in vm-mime-insert-button. This function uses the following test to determine whether to use GNU emacs make-overlay or XEmacs' make-extent. However, the test is done via a comparison of symbol names in the line (if (eq (symbol-function 'vm-make-extent) 'make-overlay)

The problem is that elp works by putting 'wrappers' around the funcitons. This wrapper breaks the eq test and so VM tries to use make-extent instead of make-overlay.

Note that I only glanced at this and this cold be completely wrong!

Tim Cross (tcross) wrote :

Forgot to say, since gnu emacs does not have make-extent, it would probably be best to just make the test more explicit by testing to see if we are running xemcs or gnu emacs and take appropriate fork rather than relying on a test based on symbol signatures. This would be more in-line with other parts of VM and I think is clearer and therefore more maintainable.

Uday Reddy (reddyuday) on 2010-06-26
Changed in vm:
status: New → Confirmed
importance: Undecided → Low
tags: added: emacs
tags: added: emacsen
removed: emacs
Uday Reddy (reddyuday) on 2010-07-22
tags: added: xemacs
removed: emacsen
Uday Reddy (reddyuday) on 2011-02-10
tags: added: emacsen
removed: xemacs
Uday Reddy (reddyuday) wrote :

Fix committed in revision 1067.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers