vm-mail-mailto-url url-decodes "body" twice

[Göran Uddeborg]

If I do

(vm-mail-to-mailto-url "mailto:<email address hidden>?subject=g%25F6ran&body=g%25F6ran")

in the *scratch* buffer I get a mail window where the subject is g%F6ran but the body is göran.

I believe this is a bug in the vm-mail-to-mailto-url function. It first goes through all known arguments ("subject" "in-reply-to" "cc" "references" "newsgroups" "body") and stores their url-decoded values in local variables. Later it first inserts all the header fields with a simple "insert". And finally it inserts the body, but when it does, it calls "vm-url-decode-string" once more on the value.

So the obvious patch is to remove this latter call:

--- lisp/vm-reply.el~ 2012-03-05 18:43:21.000000000 +0100
+++ lisp/vm-reply.el 2016-08-02 19:20:13.000000000 +0200
@@ -1378,7 +1378,7 @@
       (if (null body)
          nil
        (mail-text)
- (save-excursion (insert (vm-url-decode-string body) "\n"))
+ (save-excursion (insert body "\n"))
        ;; CRLF to LF for line breaks in the body
        (while (search-forward "\r\n" nil t)
          (replace-match "\n"))))

[Uday Reddy (reddyuday)]

Indeed, thanks for the fix!

[Uday Reddy (reddyuday)]

Rev. 1510.