Substitute print statements with logging facilities

Bug #1170924 reported by Marco Giusti
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Virtualbricks
Fix Released
Low
Marco Giusti

Bug Description

There are actually many print statements in the code that should be
replaced with logging call or removed.

 affects virtualbrick

Related branches

Changed in virtualbrick:
importance: Undecided → Low
milestone: none → 1.0
status: New → Confirmed
Changed in virtualbrick:
status: Confirmed → In Progress
assignee: nobody → mg (marco-giusti)
Revision history for this message
Marco Giusti (marco-giusti) wrote : Re: [Bug 1170924] Re: Substitute print statements with logging facilities

here a possible-not-exact list of print statements

  virtualbricks/virtualmachines.py:286: print "ERROR SETTING MASTER!!"
  virtualbricks/bricks.py:140: print "Object type: " + self.get_type()
  virtualbricks/bricks.py:141: print "Possible configuration parameter: "
  virtualbricks/bricks.py:145: print v.__name__,
  virtualbricks/bricks.py:147: print v,
  virtualbricks/bricks.py:148: print " ",
  virtualbricks/bricks.py:149: print "\t(like %s %s)" % (self.prog(), switch)
  virtualbricks/bricks.py:151: print "%s %s\tset '%s' to append this value to the command " \
  virtualbricks/bricks.py:153: print "END of help"
  virtualbricks/bricks.py:154: print
  virtualbricks/bricks.py:235: print "bad config - TCP IS NONE"
  virtualbricks/bricks.py:238: print "not connected"
  virtualbricks/bricks.py:241: print "link down"
  virtualbricks/switches.py:84: print so.path
  virtualbricks/console.py:201: print "Qemu but not VDE plug"
  virtualbricks/console.py:203: print "Not a Qemu Plug"
  virtualbricks/wires.py:199: print "bye!"
  virtualbricks/events.py:54: print "Object type: " + self.get_type()
  virtualbricks/events.py:55: print "Possible configuration parameter: "
  virtualbricks/events.py:56: print "delay=n OR add [vb-shell command] OR addsh [host-shell command]"
  virtualbricks/events.py:57: print "Example: <eventname> config delay=5"
  virtualbricks/events.py:58: print "Example: <eventname> config add new switch myswitch add n " \
  virtualbricks/events.py:60: print "Example: <eventname> config addsh touch /tmp/vbshcmd addsh " \
  virtualbricks/events.py:62: print "END of help"
  virtualbricks/events.py:63: print
  virtualbricks/events.py:154: print "bad config"
  virtualbricks/tunnels.py:70: print "System= %d" % os.system(pwdgen)
  virtualbricks/brickconfig.py:96: print "%s=%s" % (k, self[k])
  virtualbricks/brickfactory.py:416: print("Connection ok")
  virtualbricks/brickfactory.py:418: print("Connection failed")
  virtualbricks/gui/gui.py:2848: print ".",
  virtualbricks/gui/gui.py:2850: print
  virtualbricks/gui/gui.py:3191: print "connect"
  virtualbricks/tcpserver.py:121: print "Len args: %d" % len(args)
  virtualbricks/tcpserver.py:122: print "Args[0]=%s" % args[0]
  virtualbricks/tcpserver.py:131: print "Brick not found: " + args[2]

Revision history for this message
Marco Giusti (marco-giusti) wrote :

Here the updated list:

 virtualbricks/tunnels.py:70: print "System= %d" % os.system(pwdgen)
 virtualbricks/brickconfig.py:95: print "%s=%s" % (k, self[k])
 virtualbricks/gui/gui.py:2837: print ".",
 virtualbricks/gui/gui.py:2839: print
 virtualbricks/tcpserver.py:121: print "Len args: %d" % len(args)
 virtualbricks/tcpserver.py:122: print "Args[0]=%s" % args[0]
 virtualbricks/tcpserver.py:131: print "Brick not found: " + args[2]

Changed in virtualbrick:
status: In Progress → Fix Committed
Changed in virtualbrick:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Related blueprints

Remote bug watches

Bug watches keep track of this bug in other bug trackers.