Iterating twice?

[Jiri Srba]

Referring to line numbers in the merge proposal

https://code.launchpad.net/~verifydtapn-contributers/verifydtapn/timeDartPtrie/+merge/154525

Line 3489-3502: This loop should really be an else statement to the condition in line 3480-3486. Currently, we iterate over all tokens to test if any are older than c_max even though we just removed all tokens older than c_max --> twice the iterations for dead places (I know this is small, but because it is in cut it will be run a lot).

[Peter Gjøl Jensen (peter-gjoel)]

Is there any reason for that at all, can the code between 3480 - 3486 not just be omitted?

[Peter Gjøl Jensen (peter-gjoel)]

Bug-branch is:
lp:~verifydtapn-contributers/verifydtapn/CutOptimization

Check code in line 265 - 285 of NonStrictMarkingBase.cpp

[Jiri Srba (srba)]

Please, do not mark bugs as "Fixed Committed" once a branch for them is created. The workflow is as follows:

1. Bug is reported
2. If you want to fix the bug then:
    a. assign the bug to yourself (to make sure nobody else is working on the same problem)
    b. change the status to "In progress"
    c. make a new branch and link to bug to it
    d. once the branch is ready and tested, propose it as merge to trunk
3. Now we will review the branch and if all of us approve, it will be merge to trunk and only then the bug is marked
    as "Fix Committed"
4. Once the trunk version is release, the bug will be marked as "Fix Released"