Deepin compatibility

[Gleiton Campos]

Hello!

When Variety download a image from a source (Bing, Variety, Desktoppr.co, etc) the img is placed inside the folder "/home/user/Pictures/Wallpapers" even if the download folder is set to another.

There is a workaround?

OS: Deepin 15.4.1

[Alberto Salvia Novella (es20490446e)]

The work-around could be setting that same folder as the Variety folder. You can do so only if the folder is empty before doing it.

[Alberto Salvia Novella (es20490446e)]

The fix to this bug would be Variety deleting that folder as soon as it changed wallpaper, when the detected desktop was Deepin.

If you agree with this design, I can write the fix myself. Thank you.

[Alberto Salvia Novella (es20490446e)]

Also reported to:
https://github.com/varietywalls/variety/issues/4

[Alberto Salvia Novella (es20490446e)]

Developers subscribed, so they can tell us if they agree with the mentioned patch or not.

[James Lu (jlu5)]

Okay, fwiw the GitHub issue is much less confusing than this one. I find Deepin's behaviour on this part quite silly, so I think a workaround would be acceptable. We should be careful not to delete more than we mean to though, in case ~/Pictures/Wallpapers is being used to store other files too.

[Peter Levi (peterlevi)]

I'm extremely wary of Variety automatically deleting stuff, especially in bulk. This has caused problems before (e.g. the download quota implementation). Also Variety does not "own" the /home/user/Pictures/Wallpapers folder in any way, so it sounds wrong for it to delete it.

What is the exact behavior in Deepin - if I switch 3 times between the files "abc.jpg" and "xyz.jpg" as wallpapers, what files will end up in /home/user/Pictures/Wallpapers - just "abc.jpg" and "xyz.jpg" or 6 differently named files?

[Gleiton Campos (stuardbr)]

Sorry for the delay to answer.

If the files "abc.jpg" and "xyz.jpg" was downloaded from some source (Flickr, NASA, Desktoprr,etc) i will end with:

Download folder: 1 copy of each file with the original name
Wallpapers folder: 1 copy of each file with some ramdom name.

If i favorite these 2 files, i will end with more 2 files, with the original name, in the "Favorites" folder.

And if i choose "Delete to trash", the file will be COPIED to the trash. The original download folder AND the wallpapers folder will keep the files.

[James Lu (jlu5)]

Hi,

Rereading the context and Peter's response I think that this weird behaviour should really be fixed in Deepin instead of worked around in Variety. Your best bet is probably to use a specific folder for storing download images and automatically remove ~/Pictures/Wallpapers with a cronjob or something.

[Gleiton Campos (stuardbr)]

Hmm, ok. I understand. And about the delete function not working? Open another case?