Wallpapers.net doesn't work as source of wallpapers
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Variety |
Fix Released
|
Undecided
|
Unassigned | ||
variety (Ubuntu) |
Fix Released
|
Low
|
Unassigned | ||
Xenial |
Fix Committed
|
Low
|
Unassigned |
Bug Description
The listed source of wallpapers (http://
ProblemType: Bug
DistroRelease: Ubuntu 16.04
Package: variety 0.6.0-1
ProcVersionSign
Uname: Linux 4.4.0-38-generic x86_64
ApportVersion: 2.20.1-0ubuntu2.1
Architecture: amd64
CurrentDesktop: Unity
Date: Tue Sep 27 14:07:06 2016
InstallationDate: Installed on 2016-05-02 (147 days ago)
InstallationMedia: Ubuntu 16.04 LTS "Xenial Xerus" - Release amd64 (20160420.1)
PackageArchitec
SourcePackage: variety
UpgradeStatus: No upgrade log present (probably fresh install)
----
Below is the SRU template (James Lu):
[Impact]
Variety support for Wallpapers.net no longer works because the site has since changed its layout.
Newer versions of Variety have dropped support for this source, and the SRU patch below backports this removal in Xenial.
Per the bug nomination for Xenial and Section 2.1 of https:/
* An explanation of the effects of the bug on users and
* justification for backporting the fix to the stable release.
* In addition, it is helpful, but not required, to include an
explanation of how the upload fixes this bug.
[Test Case]
* In the Images list of Variety's preferences page, attempting to select Wallpapers.net ("wn") as a wallpaper source causes a silent failure as no wallpapers are found.
* Attempting to add any Wallpapers.net category (e.g. http://
[Regression Potential]
From my testing, when this patch is applied, all previous sources using Wallpapers.net are removed (this actually raises a "Unknown source" error in the console, which leads to automatic removal). This makes it possible to have a variety configuration with no wallpaper sources left after an upgrade, but this does not appear to be fatal and can be quickly fixed through the preferences page.
Some more regression potential:
- This patch removes a substantial amount of code, so it's possible that there are there are modules with lingering dependencies on the removed Wallpapers.net code. Should this be true, that code will fail to import and potentially cause Variety to crash on start.
- Part of the upstream patch removes python-lxml as a dependency, which I've done in my packaging as well. As far as I can tell (from the results of "grep lxml **/*.py"), variety/
- It may be worth checking how other features of Variety (e.g. filters) are affected by the potential removal of all Wallpaper sources (though this can be manually done by just deselecting everything in Preferences). One note is that sync is currently broken regardless of this commit due to https:/
[Other Info]
The patch I'm submitting for this bug is slightly modified from the upstream commit, and I've removed conflicting edits to the package description (debian/control) and the autogenerated po/variety.pot file.
Changed in hundredpapercuts: | |
status: | New → Triaged |
importance: | Undecided → Low |
description: | updated |
Changed in variety (Ubuntu Xenial): | |
status: | Incomplete → Triaged |
Support for Wallpapers.net was officially dropped in 0.6.1 and the related UI items were removed (upstream bugreport is https:/ /bugs.launchpad .net/variety/ +bug/1588861)