"Size" settings are ignored by application

Bug #1542233 reported by divibyzero
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Variety
Invalid
Undecided
Unassigned

Bug Description

Settings available on the "Color and size" tab does not have any impact on downloaded wallpapers. I use two monitors both on resolution 1920x1080. Unfortunately wallpapers that are being downloaded are often below 1080p and have horizontal aspect ratio. I have to delete approximately 1/3 of the wallpapers downloaded. Bug appears with various sources (but I think most commonly with reddit and NASA apod, wallhaven seems to be fine most of the time).

I have checked both
"Have landscape orientation"
"Are big at least 100% of the screen resolution"

I tried to do backup of the config file "/home/r/.config/variety/variety.conf" and downloaded wallpapers "/home/r/.config/variety/Downloaded/", and then do a clean install of variety, restore backup, but it didn't help (bug persists).

1. variety 0.5.5
2. Unity
3. Ubuntu 15.10
4. In the attached log file this is the line that corresponds to horizontal wallpaper:
INFO: 2016-02-05 10:32:46,700: save_locally() 'Image URL: http://i.imgur.com/FPGyCHr.jpg'

Revision history for this message
divibyzero (divibyzero) wrote :
description: updated
description: updated
Revision history for this message
Peter Levi (peterlevi) wrote :

Most of the online sources do not provide ways to filter by size (e.g. NASA is such, only Wallhaven and Flickr have this), so filtering happens before an image is displayed, not before it is downloaded. Variety would automatically relax the criteria though if there not enough images which match the criteria.

Changed in variety:
status: New → Invalid
Revision history for this message
Peter Levi (peterlevi) wrote :

Actually what might be the issue is that Variety uses your "total" resolution for calculations, which in your case is 3840x1080, hence very few images pass the second filter "Are big at least 100% of the screen resolution", and thus Variety relaxes the search criteria. You may want to reduce this to 50%.

Revision history for this message
divibyzero (divibyzero) wrote :

Thank you for your reply. I will lower the criteria to 50% of the screen resolution but does it apply to the width, height or both? I wouldn't like to end up with 1920x540 wallpapers being downloaded.

Maybe Variety could make a "resolution check" after downloading - and if the image does not pass it will be deleted? This could be additional factor - first fetch and filter images before downloading and then verify downloaded on disk.

Revision history for this message
Peter Levi (peterlevi) wrote :

There is no need for this check. Small images will not be used if there are enough big ones. And downloads are automatically cleaned up after some time because of the downloader folder limit. You do not have to manually clean them yourself.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.