Editing a source should keep its existing downloaded files

[Peter Levi]

The source location chnages => its target folder changes, but we still need to somehow keep the the existing downloaded files in this source. Seems best to create a symlink to the previous folder and rely on the recursiveness of the file search.

[Peter Levi (peterlevi)]

Actually for most edits it does not make sense to keep showing the old files as they are simply very different (e.g. you change a wallbase source from "stockings"/nsfw to "autumn"/sfw - you definitely don't want to keep seeing the nsfw files).

Also the potential solutions are bad: Using symlinks can very easily lead to recursive structures (e.g. if you edit and then edit back) and this is hard to avoid. Moving the files themselves seems too intrusive - you change a little thing and your disk starts trashing, this would also require better file-monitoring/event system for the history and prepared buffers and the thumbnails view. Breaks KISS...

BUT editing a source and completely losing track of the old files as it is now also seems bad.
Maybe we can ask the user and allow them to keep the old source, only disabled. Or "Edit..." should actually become "Duplicate..." and we can directly keep the old source as it is - user can then manually remove.

Needs discussion.

[Grzegorz G. (grzesiek1e5)]

"Duplicate" is a good idea.
On deleting source you can just show dialog "This will also delete images downloaded from this source. If you want to keep them, just disable this entry. What to do? [Delete source and its images/Cancel]" (Delete/Cancel is better than Yes/No for users who tend not to read warnings.)